From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Mateusz Guzik <mguzik@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Josef Bacik <jbacik@fb.com>, Jan Kara <jack@suse.cz>,
Al Viro <viro@ZenIV.linux.org.uk>,
Eric Sandeen <esandeen@redhat.com>
Subject: Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems
Date: Wed, 14 May 2014 22:17:49 -0400 [thread overview]
Message-ID: <20140515021749.GA3123@thunk.org> (raw)
In-Reply-To: <20140514215457.GC5421@dastard>
On Thu, May 15, 2014 at 07:54:57AM +1000, Dave Chinner wrote:
> On Tue, May 13, 2014 at 08:31:02PM +0200, Mateusz Guzik wrote:
> > This helps hang troubleshooting efforts when only dmesg is available.
>
> I really don't think that spamming dmesg every time a filesystem is
> frozen or thawed is a good idea. This happens a *lot* when systems
> are using snapshots, and for the most part nobody cares about
> freeze/thaw cycles because they almost always work just fine.
The problems people are worried about are when there is freezing and
unfreezing taking place in combination with a machine-level
suspend/resume cycle, no? What if we only spammed dmesg when doing a
suspend/resume?
- Ted
next prev parent reply other threads:[~2014-05-15 2:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:31 [PATCH 1/2] fs: include device name in error messages about freezing Mateusz Guzik
2014-05-13 18:31 ` [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems Mateusz Guzik
2014-05-13 18:39 ` Joe Perches
2014-05-13 18:53 ` Mateusz Guzik
2014-05-13 19:00 ` Joe Perches
2014-05-13 19:06 ` Mateusz Guzik
2014-05-14 21:54 ` Dave Chinner
2014-05-15 2:17 ` Theodore Ts'o [this message]
2014-05-15 3:04 ` Dave Chinner
2014-05-15 9:42 ` Mateusz Guzik
2014-05-15 10:01 ` Jan Kara
2014-05-15 10:43 ` Lukáš Czerner
2014-05-15 12:47 ` Theodore Ts'o
2014-05-15 13:46 ` Jan Kara
2014-05-15 14:15 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515021749.GA3123@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=esandeen@redhat.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.