From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
Date: Tue, 13 May 2014 17:51:19 -0700 [thread overview]
Message-ID: <20140514005119.16152.19787@quantum> (raw)
In-Reply-To: <1399633911-7094-6-git-send-email-boris.brezillon@free-electrons.com>
Quoting Boris BREZILLON (2014-05-09 04:11:49)
> +struct clk_ops ar100_ops = {
> + .recalc_rate = ar100_recalc_rate,
> + .determine_rate = ar100_determine_rate,
> + .set_parent = ar100_set_parent,
> + .get_parent = ar100_get_parent,
> + .set_rate = ar100_set_rate,
> +};
I might be having a brain fart, but is there a valid case for having
both a .recalc_rate and a .determine_rate? I believe that the former
will never be used and the latter will always be used by the clock
framework core.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: "Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
"Samuel Ortiz" <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"Lee Jones" <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Shuge <shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org>,
kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org,
Boris BREZILLON
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
Date: Tue, 13 May 2014 17:51:19 -0700 [thread overview]
Message-ID: <20140514005119.16152.19787@quantum> (raw)
In-Reply-To: <1399633911-7094-6-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Quoting Boris BREZILLON (2014-05-09 04:11:49)
> +struct clk_ops ar100_ops = {
> + .recalc_rate = ar100_recalc_rate,
> + .determine_rate = ar100_determine_rate,
> + .set_parent = ar100_set_parent,
> + .get_parent = ar100_get_parent,
> + .set_rate = ar100_set_rate,
> +};
I might be having a brain fart, but is there a valid case for having
both a .recalc_rate and a .determine_rate? I believe that the former
will never be used and the latter will always be used by the clock
framework core.
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: "Boris BREZILLON" <boris.brezillon@free-electrons.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Lee Jones" <lee.jones@linaro.org>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Shuge" <shuge@allwinnertech.com>,
kevin@allwinnertech.com, "Hans de Goede" <hdegoede@redhat.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dev@linux-sunxi.org,
"Boris BREZILLON" <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
Date: Tue, 13 May 2014 17:51:19 -0700 [thread overview]
Message-ID: <20140514005119.16152.19787@quantum> (raw)
In-Reply-To: <1399633911-7094-6-git-send-email-boris.brezillon@free-electrons.com>
Quoting Boris BREZILLON (2014-05-09 04:11:49)
> +struct clk_ops ar100_ops = {
> + .recalc_rate = ar100_recalc_rate,
> + .determine_rate = ar100_determine_rate,
> + .set_parent = ar100_set_parent,
> + .get_parent = ar100_get_parent,
> + .set_rate = ar100_set_rate,
> +};
I might be having a brain fart, but is there a valid case for having
both a .recalc_rate and a .determine_rate? I believe that the former
will never be used and the latter will always be used by the clock
framework core.
Regards,
Mike
next prev parent reply other threads:[~2014-05-14 0:51 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 11:11 [PATCH v3 0/7] mfd: add basic sun6i A31 PRCM support Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 1/7] reset: sunxi: document sunxi's reset controllers bindings Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 2/7] reset: sunxi: allow MFD subdevices probe Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 13:52 ` Lee Jones
2014-05-09 13:52 ` Lee Jones
2014-05-09 13:52 ` Lee Jones
2014-05-09 14:01 ` Boris BREZILLON
2014-05-09 14:01 ` Boris BREZILLON
2014-05-15 15:17 ` Maxime Ripard
2014-05-15 15:17 ` Maxime Ripard
2014-05-19 9:21 ` Lee Jones
2014-05-19 9:21 ` Lee Jones
2014-05-19 9:27 ` Maxime Ripard
2014-05-19 9:27 ` Maxime Ripard
2014-05-19 9:27 ` Maxime Ripard
2014-05-19 13:32 ` Lee Jones
2014-05-19 13:32 ` Lee Jones
2014-05-19 14:05 ` Maxime Ripard
2014-05-19 14:05 ` Maxime Ripard
2014-05-19 14:05 ` Maxime Ripard
2014-05-19 14:24 ` Lee Jones
2014-05-19 14:24 ` Lee Jones
2014-05-19 14:24 ` Lee Jones
2014-05-19 14:29 ` Lee Jones
2014-05-19 14:29 ` Lee Jones
2014-05-19 14:29 ` Lee Jones
2014-05-09 11:11 ` [PATCH v3 4/7] mfd: sun6i-prcm: document DT bindings Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-19 14:26 ` Lee Jones
2014-05-19 14:26 ` Lee Jones
2014-05-09 11:11 ` [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-13 15:09 ` Emilio López
2014-05-13 15:09 ` Emilio López
2014-05-13 15:09 ` Emilio López
2014-05-14 0:51 ` Mike Turquette [this message]
2014-05-14 0:51 ` Mike Turquette
2014-05-14 0:51 ` Mike Turquette
2014-05-14 7:30 ` Boris BREZILLON
2014-05-14 7:30 ` Boris BREZILLON
2014-05-14 7:30 ` Boris BREZILLON
2014-05-14 22:39 ` Mike Turquette
2014-05-14 22:39 ` Mike Turquette
2014-05-14 22:39 ` Mike Turquette
2014-05-09 11:11 ` [PATCH v3 6/7] clk: sunxi: document PRCM clock compatible strings Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` [PATCH v3 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-09 11:11 ` Boris BREZILLON
2014-05-13 15:17 ` Emilio López
2014-05-13 15:17 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514005119.16152.19787@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.