[PATCH 1/1] ARM: OMAP2+: enable LEDS class support

[PATCH 1/1] ARM: OMAP2+: enable LEDS class support

[Javier Martinez Canillas]

Commit 5610b8ede ("ARM: OMAP2+: AM33XX: omap2plus_defconfig:
Add support for few drivers") added support for different
drivers including GPIO based leds.

But LEDS_GPIO config option depends on LEDS_CLASS which was
not included so GPIO leds option is not selected. Adding as
built-in option since the related options are built-in too.

Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
 arch/arm/configs/omap2plus_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index a4e8d01..0a70170 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -239,6 +239,7 @@ CONFIG_SDIO_UART=y
 CONFIG_MMC_OMAP=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
 CONFIG_LEDS_GPIO=y
 CONFIG_LEDS_TRIGGERS=y
 CONFIG_LEDS_TRIGGER_TIMER=y
-- 
2.0.0.rc0

Re: [PATCH 1/1] ARM: OMAP2+: enable LEDS class support

[Tony Lindgren]

* Javier Martinez Canillas <javier@dowhile0.org> [140514 04:46]:
> Commit 5610b8ede ("ARM: OMAP2+: AM33XX: omap2plus_defconfig:
> Add support for few drivers") added support for different
> drivers including GPIO based leds.
> 
> But LEDS_GPIO config option depends on LEDS_CLASS which was
> not included so GPIO leds option is not selected. Adding as
> built-in option since the related options are built-in too.

Yeah this is already enabled with the PM related patches as
we can use the n900 debug LEDs to monitor for PM related
regressions. So patch "ARM: dts: Enable N900 keyboard sleep
leds by default" enables CONFIG_LEDS_CLASS, I've sent a pull
request for that few days ago for v3.16.

Regards,

Tony
 
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>  arch/arm/configs/omap2plus_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index a4e8d01..0a70170 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -239,6 +239,7 @@ CONFIG_SDIO_UART=y
>  CONFIG_MMC_OMAP=y
>  CONFIG_MMC_OMAP_HS=y
>  CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
>  CONFIG_LEDS_GPIO=y
>  CONFIG_LEDS_TRIGGERS=y
>  CONFIG_LEDS_TRIGGER_TIMER=y
> -- 
> 2.0.0.rc0
> 

Re: [PATCH 1/1] ARM: OMAP2+: enable LEDS class support

[Javier Martinez Canillas]

Hello Tony,

On Wed, May 14, 2014 at 5:10 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Javier Martinez Canillas <javier@dowhile0.org> [140514 04:46]:
>> Commit 5610b8ede ("ARM: OMAP2+: AM33XX: omap2plus_defconfig:
>> Add support for few drivers") added support for different
>> drivers including GPIO based leds.
>>
>> But LEDS_GPIO config option depends on LEDS_CLASS which was
>> not included so GPIO leds option is not selected. Adding as
>> built-in option since the related options are built-in too.
>
> Yeah this is already enabled with the PM related patches as
> we can use the n900 debug LEDs to monitor for PM related
> regressions. So patch "ARM: dts: Enable N900 keyboard sleep
> leds by default" enables CONFIG_LEDS_CLASS, I've sent a pull
> request for that few days ago for v3.16.
>

Ok, I didn't notice before because I was using a custom defconfig
which had it enabled.

Sorry, I missed that series somehow, glad to know that it is already enabled.

> Regards,
>
> Tony
>

Best regards,
Javier