All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org, balbi@ti.com,
	linux-mtd@lists.infradead.org, pekon@ti.com,
	ezequiel.garcia@free-electrons.com, computersforpeace@gmail.com
Subject: Re: [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards
Date: Wed, 14 May 2014 08:30:29 -0700	[thread overview]
Message-ID: <20140514153028.GC18463@atomide.com> (raw)
In-Reply-To: <1400070908-2929-1-git-send-email-rogerq@ti.com>

* Roger Quadros <rogerq@ti.com> [140514 05:36]:
> Commit c66d039197e4 broke NAND for non-DT boot on all OMAP2 and OMAP3
> boards using board_nand_init(). Following error is seen at boot
> 
> [    0.154998]  (null): Unsupported NAND ECC scheme selected
> 
> For OMAP2 and OMAP3 platforms, the ecc_opt parameter in platform data
> must be set to OMAP_ECC_HAM1_CODE_HW to work properly.
> 
> Tested on omap3-beagle c4.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Thanks applying into fixes with Cc stable v3.12+.

Regards,

Tony

>  arch/arm/mach-omap2/board-flash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c
> index ac82512..b6885e4 100644
> --- a/arch/arm/mach-omap2/board-flash.c
> +++ b/arch/arm/mach-omap2/board-flash.c
> @@ -142,7 +142,7 @@ __init board_nand_init(struct mtd_partition *nand_parts, u8 nr_parts, u8 cs,
>  	board_nand_data.nr_parts	= nr_parts;
>  	board_nand_data.devsize		= nand_type;
>  
> -	board_nand_data.ecc_opt = OMAP_ECC_BCH8_CODE_HW;
> +	board_nand_data.ecc_opt = OMAP_ECC_HAM1_CODE_HW;
>  	gpmc_nand_init(&board_nand_data, gpmc_t);
>  }
>  #endif /* CONFIG_MTD_NAND_OMAP2 || CONFIG_MTD_NAND_OMAP2_MODULE */
> -- 
> 1.8.3.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: pekon@ti.com, balbi@ti.com, ezequiel.garcia@free-electrons.com,
	computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards
Date: Wed, 14 May 2014 08:30:29 -0700	[thread overview]
Message-ID: <20140514153028.GC18463@atomide.com> (raw)
In-Reply-To: <1400070908-2929-1-git-send-email-rogerq@ti.com>

* Roger Quadros <rogerq@ti.com> [140514 05:36]:
> Commit c66d039197e4 broke NAND for non-DT boot on all OMAP2 and OMAP3
> boards using board_nand_init(). Following error is seen at boot
> 
> [    0.154998]  (null): Unsupported NAND ECC scheme selected
> 
> For OMAP2 and OMAP3 platforms, the ecc_opt parameter in platform data
> must be set to OMAP_ECC_HAM1_CODE_HW to work properly.
> 
> Tested on omap3-beagle c4.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Thanks applying into fixes with Cc stable v3.12+.

Regards,

Tony

>  arch/arm/mach-omap2/board-flash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c
> index ac82512..b6885e4 100644
> --- a/arch/arm/mach-omap2/board-flash.c
> +++ b/arch/arm/mach-omap2/board-flash.c
> @@ -142,7 +142,7 @@ __init board_nand_init(struct mtd_partition *nand_parts, u8 nr_parts, u8 cs,
>  	board_nand_data.nr_parts	= nr_parts;
>  	board_nand_data.devsize		= nand_type;
>  
> -	board_nand_data.ecc_opt = OMAP_ECC_BCH8_CODE_HW;
> +	board_nand_data.ecc_opt = OMAP_ECC_HAM1_CODE_HW;
>  	gpmc_nand_init(&board_nand_data, gpmc_t);
>  }
>  #endif /* CONFIG_MTD_NAND_OMAP2 || CONFIG_MTD_NAND_OMAP2_MODULE */
> -- 
> 1.8.3.2
> 

  reply	other threads:[~2014-05-14 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 12:35 [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards Roger Quadros
2014-05-14 12:35 ` Roger Quadros
2014-05-14 15:30 ` Tony Lindgren [this message]
2014-05-14 15:30   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514153028.GC18463@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pekon@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.