[Buildroot] [PATCH 1/2] package/rsyslog: Add missing optional dependency libcrypt

[Buildroot] [PATCH 1/2] package/rsyslog: Add missing optional dependency libcrypt

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/rsyslog/rsyslog.mk |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
index c124c02..88747b7 100644
--- a/package/rsyslog/rsyslog.mk
+++ b/package/rsyslog/rsyslog.mk
@@ -24,6 +24,7 @@ ifeq ($(BR2_PACKAGE_LIBEE),y)
 endif
 
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
+	RSYSLOG_DEPENDENCIES += libgcrypt
 	RSYSLOG_CONF_ENV += LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config
 	RSYSLOG_CONF_OPT += --enable-libgcrypt=yes
 else
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] package/rsyslog: needs MMU (fork)

[Bernd Kuhls]

fixes http://autobuild.buildroot.net/results/5c0/5c03bf3a1e4e922a18b40f854ff59d905a93a89f/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/rsyslog/Config.in |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/rsyslog/Config.in b/package/rsyslog/Config.in
index 8a84fea..82a6922 100644
--- a/package/rsyslog/Config.in
+++ b/package/rsyslog/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_RSYSLOG
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_USE_WCHAR # util-linux
 	help
 	  Rsyslog is a powerful and flexible syslog implementation
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] package/rsyslog: needs MMU (fork)

[Baruch Siach]

Hi Bernd,

On Wed, May 14, 2014 at 08:28:53PM +0200, Bernd Kuhls wrote:
> fixes http://autobuild.buildroot.net/results/5c0/5c03bf3a1e4e922a18b40f854ff59d905a93a89f/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/rsyslog/Config.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/rsyslog/Config.in b/package/rsyslog/Config.in
> index 8a84fea..82a6922 100644
> --- a/package/rsyslog/Config.in
> +++ b/package/rsyslog/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_RSYSLOG
>  	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_LARGEFILE # util-linux
> +	depends on BR2_USE_MMU # fork()

Please also update the dependencies comment.

baruch

>  	depends on BR2_USE_WCHAR # util-linux
>  	help
>  	  Rsyslog is a powerful and flexible syslog implementation
> -- 

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 2/2] package/rsyslog: needs MMU (fork)

[Bernd Kuhls]

Baruch Siach <baruch@tkos.co.il> wrote in
news:20140514183816.GI4096 at tarshish: 

>> +     depends on BR2_USE_MMU # fork()
> 
> Please also update the dependencies comment.

Hi,

afaics nowhere in buildroot exists a comment for the !BR2_USE_MMU case.

Regards, Bernd

[Buildroot] [PATCH 2/2] package/rsyslog: needs MMU (fork)

[Yann E. MORIN]

Bernd, All,

On 2014-05-14 20:57 +0200, Bernd Kuhls spake thusly:
> Baruch Siach <baruch@tkos.co.il> wrote in
> news:20140514183816.GI4096 at tarshish: 
> 
> >> +     depends on BR2_USE_MMU # fork()
> > 
> > Please also update the dependencies comment.
> 
> afaics nowhere in buildroot exists a comment for the !BR2_USE_MMU case.

Partially wrong. See:
    http://buildroot.net/downloads/manual/manual.html#_literal_config_in_literal_file


  * MMU support
    - Dependency symbol: BR2_USE_MMU
    - Comment string: no comment to be added 

So, indeed, we do not add 'MMU' in the comment, but still the depndency
should be propagated to the comment, so we'd want:

    comment "rsyslog needs a toolchain w/ largefile, wchar, threads"
        depends on BR2_USE_MMU
        depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE || !BR2_USE_WCHAR

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/2] package/rsyslog: needs MMU (fork)

[Bernd Kuhls]

"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in
news:20140514191104.GB3495 at free.fr: 

> So, indeed, we do not add 'MMU' in the comment, but still the depndency
> should be propagated to the comment, so we'd want:

Hi,

thanks for the hint, patch updated: http://patchwork.ozlabs.org/patch/348947/

Regards, Bernd

[Buildroot] [PATCH 1/2] package/rsyslog: Add missing optional dependency libcrypt

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard