From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [Qemu-trivial] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible
Date: Thu, 15 May 2014 09:42:54 +0300 [thread overview]
Message-ID: <20140515064254.GE14456@redhat.com> (raw)
In-Reply-To: <1400136137.2922.16.camel@nilsson.home.kraxel.org>
On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote:
> On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote:
> ^^^^^^^^^^
> Looks like your clock is _way_ off.
>
> > + if (!pci->compat) {
> > + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> > + }
>
> > static Property serial_pci_properties[] = {
> > DEFINE_PROP_CHR("chardev", PCISerialState, state.chr),
> > + DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0),
> > DEFINE_PROP_END_OF_LIST(),
> > };
>
> > + {\
> > + .driver = "pci-serial",\
> > + .property = "compat",\
> > + .value = stringify(1),\
> > + },\
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
> mst, do you take that through the pci tree?
>
> cheers,
> Gerd
>
Yes but I'd like the property renamed. Agree?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible
Date: Thu, 15 May 2014 09:42:54 +0300 [thread overview]
Message-ID: <20140515064254.GE14456@redhat.com> (raw)
In-Reply-To: <1400136137.2922.16.camel@nilsson.home.kraxel.org>
On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote:
> On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote:
> ^^^^^^^^^^
> Looks like your clock is _way_ off.
>
> > + if (!pci->compat) {
> > + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> > + }
>
> > static Property serial_pci_properties[] = {
> > DEFINE_PROP_CHR("chardev", PCISerialState, state.chr),
> > + DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0),
> > DEFINE_PROP_END_OF_LIST(),
> > };
>
> > + {\
> > + .driver = "pci-serial",\
> > + .property = "compat",\
> > + .value = stringify(1),\
> > + },\
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
> mst, do you take that through the pci tree?
>
> cheers,
> Gerd
>
Yes but I'd like the property renamed. Agree?
next prev parent reply other threads:[~2014-05-15 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 20:00 [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible BALATON Zoltan
2014-05-14 20:01 ` [Qemu-trivial] " BALATON Zoltan
2014-05-15 6:40 ` Michael S. Tsirkin
2014-05-15 6:40 ` [Qemu-devel] " Michael S. Tsirkin
2014-05-15 6:42 ` [Qemu-trivial] " Gerd Hoffmann
2014-05-15 6:42 ` [Qemu-devel] " Gerd Hoffmann
2014-05-15 6:42 ` Michael S. Tsirkin [this message]
2014-05-15 6:42 ` Michael S. Tsirkin
2014-05-15 6:53 ` [Qemu-trivial] " Gerd Hoffmann
2014-05-15 6:53 ` [Qemu-devel] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515064254.GE14456@redhat.com \
--to=mst@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.