From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 2/2] ARM: ioremap: Add IO mapping space reused support.
Date: Thu, 15 May 2014 11:17:34 +0100 [thread overview]
Message-ID: <20140515101734.GA14737@localhost> (raw)
In-Reply-To: <CAHPCO9FRfR5p1N5v7mUk4hUYdPvqfLN6nW1LcnC83sU86ZFbZA@mail.gmail.com>
On Tue, May 13, 2014 at 09:45:08AM +0800, Richard Lee wrote:
> > On Mon, May 12, 2014 at 3:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 12 May 2014 10:19:55 Richard Lee wrote:
> >> For the IO mapping, for the same physical address space maybe
> >> mapped more than one time, for example, in some SoCs:
> >> 0x20000000 ~ 0x20001000: are global control IO physical map,
> >> and this range space will be used by many drivers.
> >> And then if each driver will do the same ioremap operation, we
> >> will waste to much malloc virtual spaces.
> >>
> >> This patch add IO mapping space reused support.
> >>
> >> Signed-off-by: Richard Lee <superlibj@gmail.com>
> >
> > What happens if the first driver then unmaps the area?
>
> If the first driver will unmap the area, it shouldn't do any thing
> except decreasing the 'used' counter.
It's still racy. What if the first driver manage to decrement the used
counter, unmaps the regions but doesn't yet free the vm_struct while
another driver finds the vm_struct, increments the used count and
assumes it can use it?
BTW, vm_area_is_aready_to_free() name implies a query but it has
side-effects like decrementing the counter.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Richard Lee <superlibj8301@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Richard Lee <superlibj@gmail.com>
Subject: Re: [RFC][PATCH 2/2] ARM: ioremap: Add IO mapping space reused support.
Date: Thu, 15 May 2014 11:17:34 +0100 [thread overview]
Message-ID: <20140515101734.GA14737@localhost> (raw)
In-Reply-To: <CAHPCO9FRfR5p1N5v7mUk4hUYdPvqfLN6nW1LcnC83sU86ZFbZA@mail.gmail.com>
On Tue, May 13, 2014 at 09:45:08AM +0800, Richard Lee wrote:
> > On Mon, May 12, 2014 at 3:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 12 May 2014 10:19:55 Richard Lee wrote:
> >> For the IO mapping, for the same physical address space maybe
> >> mapped more than one time, for example, in some SoCs:
> >> 0x20000000 ~ 0x20001000: are global control IO physical map,
> >> and this range space will be used by many drivers.
> >> And then if each driver will do the same ioremap operation, we
> >> will waste to much malloc virtual spaces.
> >>
> >> This patch add IO mapping space reused support.
> >>
> >> Signed-off-by: Richard Lee <superlibj@gmail.com>
> >
> > What happens if the first driver then unmaps the area?
>
> If the first driver will unmap the area, it shouldn't do any thing
> except decreasing the 'used' counter.
It's still racy. What if the first driver manage to decrement the used
counter, unmaps the regions but doesn't yet free the vm_struct while
another driver finds the vm_struct, increments the used count and
assumes it can use it?
BTW, vm_area_is_aready_to_free() name implies a query but it has
side-effects like decrementing the counter.
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Richard Lee <superlibj8301@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Richard Lee <superlibj@gmail.com>
Subject: Re: [RFC][PATCH 2/2] ARM: ioremap: Add IO mapping space reused support.
Date: Thu, 15 May 2014 11:17:34 +0100 [thread overview]
Message-ID: <20140515101734.GA14737@localhost> (raw)
In-Reply-To: <CAHPCO9FRfR5p1N5v7mUk4hUYdPvqfLN6nW1LcnC83sU86ZFbZA@mail.gmail.com>
On Tue, May 13, 2014 at 09:45:08AM +0800, Richard Lee wrote:
> > On Mon, May 12, 2014 at 3:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 12 May 2014 10:19:55 Richard Lee wrote:
> >> For the IO mapping, for the same physical address space maybe
> >> mapped more than one time, for example, in some SoCs:
> >> 0x20000000 ~ 0x20001000: are global control IO physical map,
> >> and this range space will be used by many drivers.
> >> And then if each driver will do the same ioremap operation, we
> >> will waste to much malloc virtual spaces.
> >>
> >> This patch add IO mapping space reused support.
> >>
> >> Signed-off-by: Richard Lee <superlibj@gmail.com>
> >
> > What happens if the first driver then unmaps the area?
>
> If the first driver will unmap the area, it shouldn't do any thing
> except decreasing the 'used' counter.
It's still racy. What if the first driver manage to decrement the used
counter, unmaps the regions but doesn't yet free the vm_struct while
another driver finds the vm_struct, increments the used count and
assumes it can use it?
BTW, vm_area_is_aready_to_free() name implies a query but it has
side-effects like decrementing the counter.
--
Catalin
next prev parent reply other threads:[~2014-05-15 10:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 2:19 [RFC][PATCH 0/2] Add IO mapping space reused support Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-12 2:19 ` [RFC][PATCH 1/2] mm/vmalloc: Add IO mapping space reused interface Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-13 3:13 ` Rob Herring
2014-05-13 3:13 ` Rob Herring
2014-05-13 3:13 ` Rob Herring
2014-05-13 6:21 ` Richard Lee
2014-05-13 6:21 ` Richard Lee
2014-05-13 6:21 ` Richard Lee
2014-05-12 2:19 ` [RFC][PATCH 2/2] ARM: ioremap: Add IO mapping space reused support Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-12 2:19 ` Richard Lee
2014-05-12 7:51 ` Arnd Bergmann
2014-05-12 7:51 ` Arnd Bergmann
2014-05-12 7:51 ` Arnd Bergmann
2014-05-13 1:45 ` Richard Lee
2014-05-13 1:45 ` Richard Lee
2014-05-13 1:45 ` Richard Lee
2014-05-13 8:43 ` Arnd Bergmann
2014-05-13 8:43 ` Arnd Bergmann
2014-05-13 8:43 ` Arnd Bergmann
2014-05-14 2:13 ` Richard Lee
2014-05-14 2:13 ` Richard Lee
2014-05-14 2:13 ` Richard Lee
2014-05-15 10:17 ` Catalin Marinas [this message]
2014-05-15 10:17 ` Catalin Marinas
2014-05-15 10:17 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515101734.GA14737@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.