From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
Luca Coelho <luca@coelho.fi>,
michal.kazior@tieto.com, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks
Date: Fri, 16 May 2014 11:34:41 -0400 [thread overview]
Message-ID: <20140516153441.GD3431@tuxdriver.com> (raw)
In-Reply-To: <87y4y13im2.fsf@kamboji.qca.qualcomm.com>
On Fri, May 16, 2014 at 05:26:13PM +0300, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
>
> > From: Luciano Coelho <luciano.coelho@intel.com>
> >
> > The channel_switch_beacon callback is optional, so it doesn't have to
> > be defined if it's not going to do anything useful with it. Both
> > ath9k and ath10k define the callback and just returns. This commit
> > removes them.
> >
> > Cc: Michal Kazior <michal.kazior@tieto.com>
> > Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> > ---
> >
> > I'm plannnig to remove the channel_switch_beacon callback (actually,
> > replace it with a more generic one that can be used for STA and other
> > iftypes too) and ath9k/ath10k are the only (non) users of it. ;)
>
> John, I'm planning to take this as I think we will get less conflicts
> that way. But let me know if you want it instead.
No, that's good. You will take the ath9k part too, right?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: John W. Linville <linville@tuxdriver.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks
Date: Fri, 16 May 2014 11:34:41 -0400 [thread overview]
Message-ID: <20140516153441.GD3431@tuxdriver.com> (raw)
In-Reply-To: <87y4y13im2.fsf@kamboji.qca.qualcomm.com>
On Fri, May 16, 2014 at 05:26:13PM +0300, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
>
> > From: Luciano Coelho <luciano.coelho@intel.com>
> >
> > The channel_switch_beacon callback is optional, so it doesn't have to
> > be defined if it's not going to do anything useful with it. Both
> > ath9k and ath10k define the callback and just returns. This commit
> > removes them.
> >
> > Cc: Michal Kazior <michal.kazior@tieto.com>
> > Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> > ---
> >
> > I'm plannnig to remove the channel_switch_beacon callback (actually,
> > replace it with a more generic one that can be used for STA and other
> > iftypes too) and ath9k/ath10k are the only (non) users of it. ;)
>
> John, I'm planning to take this as I think we will get less conflicts
> that way. But let me know if you want it instead.
No, that's good. You will take the ath9k part too, right?
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Luca Coelho <luca@coelho.fi>,
ath10k@lists.infradead.org, ath9k-devel@venema.h4ckr.net,
linux-wireless@vger.kernel.org, michal.kazior@tieto.com
Subject: Re: [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks
Date: Fri, 16 May 2014 11:34:41 -0400 [thread overview]
Message-ID: <20140516153441.GD3431@tuxdriver.com> (raw)
In-Reply-To: <87y4y13im2.fsf@kamboji.qca.qualcomm.com>
On Fri, May 16, 2014 at 05:26:13PM +0300, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
>
> > From: Luciano Coelho <luciano.coelho@intel.com>
> >
> > The channel_switch_beacon callback is optional, so it doesn't have to
> > be defined if it's not going to do anything useful with it. Both
> > ath9k and ath10k define the callback and just returns. This commit
> > removes them.
> >
> > Cc: Michal Kazior <michal.kazior@tieto.com>
> > Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> > ---
> >
> > I'm plannnig to remove the channel_switch_beacon callback (actually,
> > replace it with a more generic one that can be used for STA and other
> > iftypes too) and ath9k/ath10k are the only (non) users of it. ;)
>
> John, I'm planning to take this as I think we will get less conflicts
> that way. But let me know if you want it instead.
No, that's good. You will take the ath9k part too, right?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-05-16 15:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:55 [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks Luca Coelho
2014-05-16 13:55 ` Luca Coelho
2014-05-16 13:55 ` [ath9k-devel] " Luca Coelho
2014-05-16 14:26 ` Kalle Valo
2014-05-16 14:26 ` Kalle Valo
2014-05-16 14:26 ` [ath9k-devel] " Kalle Valo
2014-05-16 15:34 ` John W. Linville [this message]
2014-05-16 15:34 ` John W. Linville
2014-05-16 15:34 ` [ath9k-devel] " John W. Linville
2014-05-16 15:54 ` Kalle Valo
2014-05-16 15:54 ` Kalle Valo
2014-05-16 15:54 ` [ath9k-devel] " Kalle Valo
2014-05-23 8:32 ` Kalle Valo
2014-05-23 8:32 ` Kalle Valo
2014-05-23 8:32 ` [ath9k-devel] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516153441.GD3431@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath10k@lists.infradead.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.