All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Alex Shi <alex.shi@linaro.org>,
	khilman@linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled
Date: Fri, 16 May 2014 14:29:42 -0700	[thread overview]
Message-ID: <20140516212942.GK12881@atomide.com> (raw)
In-Reply-To: <537615EA.3020809@ti.com>

* Santosh Shilimkar <santosh.shilimkar@ti.com> [140516 06:43]:
> Tony,
> 
> On Thursday 15 May 2014 02:29 PM, Santosh Shilimkar wrote:
> > On Thursday 15 May 2014 01:54 PM, Santosh Shilimkar wrote:
> >> On Thursday 15 May 2014 01:50 PM, Daniel Lezcano wrote:
> >>> On 05/15/2014 07:03 PM, Santosh Shilimkar wrote:
> > 
> > [..]
> > 
> >>>>> With above mentioned change, it should work. Other alternatives is OMAP4 driver does
> >>>>> its won registration where it can start the timer. The way it was before the
> >>>>> consolidation.
> >>>>>
> >>>>> Ofcourse if you have better fix, then great.
> >>>>>
> >>>> What is your suggestion. We *must* fix the regression asap. I think
> >>>> $subject patch with an update to bctimer start under CPUIDLE_FLAG_COUPLED
> >>>> seems a good way forward.
> >>>>
> >>>> Do let me know.
> >>>
> >>> Did you see Alex Shi's email [cc'ed] ? Reverting this change makes the panda ES to hang.
> >>>
> >> The hang is definitely due to the bctimer not started. As I said, I assumed it was and
> >> then you corrected saying it is under the flag.
> >>
> >>> I am not convinced the culprit is this code you are trying to revert.
> >>>
> >> fair enough. Thats why I said if you have an alternative fix thats great.
> >>
> > For record, below is updated patch with bctimer started which
> > was missed in earlier version. I haven't tested it though.
> > 
> > Alex,
> > Please give a try with your test-case and see if you still see the hang.
> > Am just curious about your issue and hence the request..
> > 
> Alex tested below patch and he don't see the hang so the patch is
> addressing the issue.
> 
> If Daniel works out an alternate fix to avoid reverts, that will be great
> but if not, we should merge the below patch. I let you take call on it.
 
Daniel any news on this?

And just to recap, this problem can be reproduced with current
Linux next with omap2plus_defconfig with CONFIG_CPU_IDLE enabled. The
system should hang during the boot at some point.

And for the record, the omap3 hang fix is now posted to the lists as
"[PATCH] ARM: OMAP2+: Fix DMA hang after off-idle". This should not
have anything to do with the omap4 cpu_idle hang as omap4 does not
currently lose context during idle.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled
Date: Fri, 16 May 2014 14:29:42 -0700	[thread overview]
Message-ID: <20140516212942.GK12881@atomide.com> (raw)
In-Reply-To: <537615EA.3020809@ti.com>

* Santosh Shilimkar <santosh.shilimkar@ti.com> [140516 06:43]:
> Tony,
> 
> On Thursday 15 May 2014 02:29 PM, Santosh Shilimkar wrote:
> > On Thursday 15 May 2014 01:54 PM, Santosh Shilimkar wrote:
> >> On Thursday 15 May 2014 01:50 PM, Daniel Lezcano wrote:
> >>> On 05/15/2014 07:03 PM, Santosh Shilimkar wrote:
> > 
> > [..]
> > 
> >>>>> With above mentioned change, it should work. Other alternatives is OMAP4 driver does
> >>>>> its won registration where it can start the timer. The way it was before the
> >>>>> consolidation.
> >>>>>
> >>>>> Ofcourse if you have better fix, then great.
> >>>>>
> >>>> What is your suggestion. We *must* fix the regression asap. I think
> >>>> $subject patch with an update to bctimer start under CPUIDLE_FLAG_COUPLED
> >>>> seems a good way forward.
> >>>>
> >>>> Do let me know.
> >>>
> >>> Did you see Alex Shi's email [cc'ed] ? Reverting this change makes the panda ES to hang.
> >>>
> >> The hang is definitely due to the bctimer not started. As I said, I assumed it was and
> >> then you corrected saying it is under the flag.
> >>
> >>> I am not convinced the culprit is this code you are trying to revert.
> >>>
> >> fair enough. Thats why I said if you have an alternative fix thats great.
> >>
> > For record, below is updated patch with bctimer started which
> > was missed in earlier version. I haven't tested it though.
> > 
> > Alex,
> > Please give a try with your test-case and see if you still see the hang.
> > Am just curious about your issue and hence the request..
> > 
> Alex tested below patch and he don't see the hang so the patch is
> addressing the issue.
> 
> If Daniel works out an alternate fix to avoid reverts, that will be great
> but if not, we should merge the below patch. I let you take call on it.
 
Daniel any news on this?

And just to recap, this problem can be reproduced with current
Linux next with omap2plus_defconfig with CONFIG_CPU_IDLE enabled. The
system should hang during the boot at some point.

And for the record, the omap3 hang fix is now posted to the lists as
"[PATCH] ARM: OMAP2+: Fix DMA hang after off-idle". This should not
have anything to do with the omap4 cpu_idle hang as omap4 does not
currently lose context during idle.

Regards,

Tony

  reply	other threads:[~2014-05-16 21:29 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 14:39 [PATCH] ARM: OMAP4: Fix the boot regression with CPU_IDLE enabled Santosh Shilimkar
2014-05-13 14:39 ` Santosh Shilimkar
2014-05-14 15:22 ` Tony Lindgren
2014-05-14 15:22   ` Tony Lindgren
2014-05-14 19:44 ` Daniel Lezcano
2014-05-14 19:44   ` Daniel Lezcano
2014-05-14 19:50   ` Santosh Shilimkar
2014-05-14 19:50     ` Santosh Shilimkar
2014-05-14 20:02     ` Daniel Lezcano
2014-05-14 20:02       ` Daniel Lezcano
2014-05-14 20:56       ` Tony Lindgren
2014-05-14 20:56         ` Tony Lindgren
2014-05-14 23:31         ` Tony Lindgren
2014-05-14 23:31           ` Tony Lindgren
2014-05-16  0:13           ` Tony Lindgren
2014-05-16  0:13             ` Tony Lindgren
2014-05-16  0:40             ` Tony Lindgren
2014-05-16  0:40               ` Tony Lindgren
2014-05-14 21:18       ` Santosh Shilimkar
2014-05-14 21:18         ` Santosh Shilimkar
2014-05-15 17:03         ` Santosh Shilimkar
2014-05-15 17:03           ` Santosh Shilimkar
2014-05-15 17:50           ` Daniel Lezcano
2014-05-15 17:50             ` Daniel Lezcano
2014-05-15 17:54             ` Santosh Shilimkar
2014-05-15 17:54               ` Santosh Shilimkar
2014-05-15 18:29               ` Santosh Shilimkar
2014-05-15 18:29                 ` Santosh Shilimkar
2014-05-16  0:33                 ` Alex Shi
2014-05-16  0:33                   ` Alex Shi
2014-05-16 13:43                 ` Santosh Shilimkar
2014-05-16 13:43                   ` Santosh Shilimkar
2014-05-16 21:29                   ` Tony Lindgren [this message]
2014-05-16 21:29                     ` Tony Lindgren
2014-05-19 16:45                     ` Daniel Lezcano
2014-05-19 16:45                       ` Daniel Lezcano
2014-05-19 17:23                       ` Tony Lindgren
2014-05-19 17:23                         ` Tony Lindgren
2014-05-19 17:34                         ` Santosh Shilimkar
2014-05-19 17:34                           ` Santosh Shilimkar
2014-05-19 17:51                           ` Tony Lindgren
2014-05-19 17:51                             ` Tony Lindgren
2014-05-19 18:06                             ` Daniel Lezcano
2014-05-19 18:06                               ` Daniel Lezcano
2014-05-19 19:36                               ` Tony Lindgren
2014-05-19 19:36                                 ` Tony Lindgren
2014-05-19 19:45                                 ` Daniel Lezcano
2014-05-19 19:45                                   ` Daniel Lezcano
2014-05-19 21:18                                   ` Tobias Jakobi
2014-05-19 21:18                                     ` Tobias Jakobi
2014-05-19 22:42                                     ` Tony Lindgren
2014-05-19 22:42                                       ` Tony Lindgren
2014-05-23 14:44                                     ` Tony Lindgren
2014-05-23 14:44                                       ` Tony Lindgren
2014-05-23 18:32                                       ` Tony Lindgren
2014-05-23 18:32                                         ` Tony Lindgren
     [not found]                                         ` <CAKnoXLxj42veWCbRjX98iT3FNAb92J4yR+UAL716JFSOb=pcrQ@mail.gmail.com>
2014-05-27 20:34                                           ` Tony Lindgren
2014-05-27 20:34                                             ` Tony Lindgren
2014-05-27 21:03                                             ` Santosh Shilimkar
2014-05-27 21:03                                               ` Santosh Shilimkar
2014-05-27 21:06                                               ` Daniel Lezcano
2014-05-27 21:06                                                 ` Daniel Lezcano
2014-05-19 20:00                                 ` Santosh Shilimkar
2014-05-19 20:00                                   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140516212942.GK12881@atomide.com \
    --to=tony@atomide.com \
    --cc=alex.shi@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.