All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirill Tkhai <tkhai@yandex.ru>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, tkhai@yandex.ru, mingo@redhat.com,
	stable@vger.kernel.org, juri.lelli@gmail.com
Subject: [PATCH] sched/dl: Fix race between dl_task_timer() and sched_setaffinity()
Date: Sat, 17 May 2014 01:30:03 +0400	[thread overview]
Message-ID: <20140516213003.10384.7946.stgit@localhost> (raw)

The race is in unlocked task_rq() access. In pair with parallel
call of sched_setaffinity() it may be a reason of corruption
of internal rq's data.

Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
CC: Juri Lelli <juri.lelli@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@redhat.com>
Cc: <stable@vger.kernel.org> # v3.14
---
 kernel/sched/deadline.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 800e99b..ffb023a 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -513,9 +513,16 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
 						     struct sched_dl_entity,
 						     dl_timer);
 	struct task_struct *p = dl_task_of(dl_se);
-	struct rq *rq = task_rq(p);
+	struct rq *rq;
+again:
+	rq = task_rq(p);
 	raw_spin_lock(&rq->lock);
 
+	if (unlikely(rq != task_rq(p))) {
+		raw_spin_unlock(&rq->lock);
+		goto again;
+	}
+
 	/*
 	 * We need to take care of a possible races here. In fact, the
 	 * task might have changed its scheduling policy to something


             reply	other threads:[~2014-05-16 21:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 21:30 Kirill Tkhai [this message]
2014-05-19 13:12 ` [PATCH] sched/dl: Fix race between dl_task_timer() and sched_setaffinity() Juri Lelli
2014-05-19 19:31   ` Kirill Tkhai
2014-05-19 19:31     ` Kirill Tkhai
2014-05-20  0:00     ` Peter Zijlstra
2014-05-20  5:08       ` Kirill Tkhai
2014-05-20  5:08         ` Kirill Tkhai
2014-05-20  6:07         ` Kirill Tkhai
2014-05-20  6:07           ` Kirill Tkhai
2014-05-20  7:53         ` Peter Zijlstra
2014-05-20  7:53           ` Peter Zijlstra
2014-05-20  8:17           ` Juri Lelli
2014-05-20  8:17             ` Juri Lelli
2014-05-20  9:33             ` Kirill Tkhai
2014-05-20  9:33               ` Kirill Tkhai
2014-05-21  7:29               ` Peter Zijlstra
2014-06-05 14:33               ` [tip:sched/urgent] sched/dl: Fix race in dl_task_timer() tip-bot for Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140516213003.10384.7946.stgit@localhost \
    --to=tkhai@yandex.ru \
    --cc=juri.lelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.