From: Peter Zijlstra <peterz@infradead.org>
To: Kirill Tkhai <tkhai@yandex.ru>
Cc: Juri Lelli <juri.lelli@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] sched/dl: Fix race between dl_task_timer() and sched_setaffinity()
Date: Tue, 20 May 2014 02:00:26 +0200 [thread overview]
Message-ID: <20140520000026.GD11096@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <783871400527879@web2j.yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Mon, May 19, 2014 at 11:31:19PM +0400, Kirill Tkhai wrote:
> @@ -513,9 +513,17 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
> struct sched_dl_entity,
> dl_timer);
> struct task_struct *p = dl_task_of(dl_se);
> - struct rq *rq = task_rq(p);
> + struct rq *rq;
> +again:
> + rq = task_rq(p);
> raw_spin_lock(&rq->lock);
>
> + if (unlikely(rq != task_rq(p))) {
> + /* Task was moved, retrying. */
> + raw_spin_unlock(&rq->lock);
> + goto again;
> + }
> +
That thing is called: rq = __task_rq_lock(p);
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-20 0:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 21:30 [PATCH] sched/dl: Fix race between dl_task_timer() and sched_setaffinity() Kirill Tkhai
2014-05-19 13:12 ` Juri Lelli
2014-05-19 19:31 ` Kirill Tkhai
2014-05-19 19:31 ` Kirill Tkhai
2014-05-20 0:00 ` Peter Zijlstra [this message]
2014-05-20 5:08 ` Kirill Tkhai
2014-05-20 5:08 ` Kirill Tkhai
2014-05-20 6:07 ` Kirill Tkhai
2014-05-20 6:07 ` Kirill Tkhai
2014-05-20 7:53 ` Peter Zijlstra
2014-05-20 7:53 ` Peter Zijlstra
2014-05-20 8:17 ` Juri Lelli
2014-05-20 8:17 ` Juri Lelli
2014-05-20 9:33 ` Kirill Tkhai
2014-05-20 9:33 ` Kirill Tkhai
2014-05-21 7:29 ` Peter Zijlstra
2014-06-05 14:33 ` [tip:sched/urgent] sched/dl: Fix race in dl_task_timer() tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520000026.GD11096@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.