* Re: [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c
@ 2014-05-18 18:52 Sam Ravnborg
2014-05-19 8:26 ` Toralf Förster
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sam Ravnborg @ 2014-05-18 18:52 UTC (permalink / raw)
To: sparclinux
On Sun, May 18, 2014 at 07:51:00PM +0200, Toralf Förster wrote:
> found by cppcheck
>
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
[Toralf - fist mail was accidently only sent to
you - something looks fishy in the To: line of your mail]
> ---
> arch/sparc/kernel/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c
> index a364000..7f41d40 100644
> --- a/arch/sparc/kernel/sysfs.c
> +++ b/arch/sparc/kernel/sysfs.c
> @@ -151,7 +151,7 @@ static ssize_t store_mmustat_enable(struct device *s,
> size_t count)
> {
> unsigned long val, err;
> - int ret = sscanf(buf, "%ld", &val);
> + int ret = sscanf(buf, "%lu", &val);
>
> if (ret != 1)
> return -EINVAL;
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c
2014-05-18 18:52 [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c Sam Ravnborg
@ 2014-05-19 8:26 ` Toralf Förster
2014-05-19 8:48 ` Sam Ravnborg
2014-05-21 19:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Toralf Förster @ 2014-05-19 8:26 UTC (permalink / raw)
To: sparclinux
found by cppcheck
Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
---
arch/sparc/kernel/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c
index a364000..7f41d40 100644
--- a/arch/sparc/kernel/sysfs.c
+++ b/arch/sparc/kernel/sysfs.c
@@ -151,7 +151,7 @@ static ssize_t store_mmustat_enable(struct device *s,
size_t count)
{
unsigned long val, err;
- int ret = sscanf(buf, "%ld", &val);
+ int ret = sscanf(buf, "%lu", &val);
if (ret != 1)
return -EINVAL;
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c
2014-05-18 18:52 [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c Sam Ravnborg
2014-05-19 8:26 ` Toralf Förster
@ 2014-05-19 8:48 ` Sam Ravnborg
2014-05-21 19:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2014-05-19 8:48 UTC (permalink / raw)
To: sparclinux
On Mon, May 19, 2014 at 10:26:31AM +0200, Toralf Förster wrote:
> found by cppcheck
>
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> arch/sparc/kernel/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c
> index a364000..7f41d40 100644
> --- a/arch/sparc/kernel/sysfs.c
> +++ b/arch/sparc/kernel/sysfs.c
> @@ -151,7 +151,7 @@ static ssize_t store_mmustat_enable(struct device *s,
> size_t count)
> {
> unsigned long val, err;
> - int ret = sscanf(buf, "%ld", &val);
> + int ret = sscanf(buf, "%lu", &val);
>
> if (ret != 1)
> return -EINVAL;
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c
2014-05-18 18:52 [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c Sam Ravnborg
2014-05-19 8:26 ` Toralf Förster
2014-05-19 8:48 ` Sam Ravnborg
@ 2014-05-21 19:55 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-05-21 19:55 UTC (permalink / raw)
To: sparclinux
From: Toralf Förster <toralf.foerster@gmx.de>
Date: Mon, 19 May 2014 10:26:31 +0200
> found by cppcheck
>
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Applied, thank you.
I adjusted your Subject line to have an appropriate subsystem
prefix, in this case "sparc64: "
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-21 19:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-18 18:52 [PATCH] fix format string mismatch in arch/sparc/kernel/sysfs.c Sam Ravnborg
2014-05-19 8:26 ` Toralf Förster
2014-05-19 8:48 ` Sam Ravnborg
2014-05-21 19:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.