From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 resend 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Mon, 19 May 2014 20:50:33 +0000 [thread overview]
Message-ID: <20140519205033.GE11945@atomide.com> (raw)
In-Reply-To: <1400532162-29483-8-git-send-email-alexandre.belloni@free-electrons.com>
* Alexandre Belloni <alexandre.belloni@free-electrons.com> [140519 13:44]:
Missing description?
Presumably you'll fix that so:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
> };
>
> static struct led_pwm pwm_leds[] = {
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Jingoo Han <jg1.han@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org, linux-leds@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 resend 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Mon, 19 May 2014 13:50:33 -0700 [thread overview]
Message-ID: <20140519205033.GE11945@atomide.com> (raw)
In-Reply-To: <1400532162-29483-8-git-send-email-alexandre.belloni@free-electrons.com>
* Alexandre Belloni <alexandre.belloni@free-electrons.com> [140519 13:44]:
Missing description?
Presumably you'll fix that so:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
> };
>
> static struct led_pwm pwm_leds[] = {
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 resend 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup
Date: Mon, 19 May 2014 13:50:33 -0700 [thread overview]
Message-ID: <20140519205033.GE11945@atomide.com> (raw)
In-Reply-To: <1400532162-29483-8-git-send-email-alexandre.belloni@free-electrons.com>
* Alexandre Belloni <alexandre.belloni@free-electrons.com> [140519 13:44]:
Missing description?
Presumably you'll fix that so:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f27e1ec90b5e..54c135a5b4f7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -61,14 +61,8 @@
>
> static struct pwm_lookup pwm_lookup[] = {
> /* LEDB -> PMU_STAT */
> - {
> - .provider = "twl-pwmled",
> - .index = 1,
> - .dev_id = "leds_pwm",
> - .con_id = "beagleboard::pmu_stat",
> - .period = 7812500,
> - .polarity = PWM_POLARITY_NORMAL,
> - },
> + PWM_LOOKUP("twl-pwmled", 1, "leds_pwm", "beagleboard::pmu_stat",
> + 7812500, PWM_POLARITY_NORMAL),
> };
>
> static struct led_pwm pwm_leds[] = {
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-05-19 20:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 20:42 [PATCHv2 resend 00/11] improve PWM lookup support without device tree Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 01/11] pwm: add period and polarity to struct pwm_lookup Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 02/11] ARM: shmobile: Armadillo 800 EVA: initialize all struct pwm_lookup members Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 03/11] pwm: renesas-tpu: remove useless struct tpu_pwm_platform_data Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 04/11] ARM: OMAP3: Beagle: initialize all the struct pwm_lookup members Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:49 ` Tony Lindgren
2014-05-19 20:49 ` Tony Lindgren
2014-05-19 20:49 ` Tony Lindgren
2014-05-19 20:42 ` [PATCHv2 resend 05/11] ARM: pxa: hx4700: " Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 06/11] pwm: modify PWM_LOOKUP to initialize all " Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 07/11] ARM: OMAP3: Beagle: use PWM_LOOKUP to initialize struct pwm_lookup Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:50 ` Tony Lindgren [this message]
2014-05-19 20:50 ` Tony Lindgren
2014-05-19 20:50 ` Tony Lindgren
2014-05-19 20:42 ` [PATCHv2 resend 08/11] ARM: shmobile: Armadillo 800 EVA: use PWM_LOOKUP to initialize struct pwm_loo Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 08/11] ARM: shmobile: Armadillo 800 EVA: use PWM_LOOKUP to initialize struct pwm_lookup Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 09/11] ARM: pxa: hx4700: " Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 10/11] leds: leds-pwm: retrieve configured pwm period Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` [PATCHv2 resend 11/11] backlight: pwm_bl: " Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 20:42 ` Alexandre Belloni
2014-05-19 21:08 ` [PATCHv2 resend 00/11] improve PWM lookup support without device tree Thierry Reding
2014-05-19 21:08 ` Thierry Reding
2014-05-19 21:08 ` Thierry Reding
2014-05-19 22:39 ` Simon Horman
2014-05-19 22:39 ` Simon Horman
2014-05-19 22:39 ` Simon Horman
2014-05-20 0:55 ` Laurent Pinchart
2014-05-20 0:55 ` Laurent Pinchart
2014-05-20 0:55 ` Laurent Pinchart
2014-05-20 0:55 ` Laurent Pinchart
2014-05-20 17:27 ` Philipp Zabel
2014-05-20 17:27 ` Philipp Zabel
2014-05-20 17:27 ` Philipp Zabel
2014-05-21 9:16 ` Thierry Reding
2014-05-21 9:16 ` Thierry Reding
2014-05-21 9:16 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519205033.GE11945@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.