From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org,
benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com,
mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org,
mingo@kernel.org, dave.hansen@intel.com
Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc
Date: Tue, 20 May 2014 00:32:01 -0700 [thread overview]
Message-ID: <20140520003201.a2360d5d.akpm@linux-foundation.org> (raw)
In-Reply-To: <87oaythsvk.fsf@rustcorp.com.au>
On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> > Andrew Morton wrote:
> >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> >>
> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be
> >> > the order of the fault-around size in bytes, and fault_around_pages()
> >> > use 1UL << (fault_around_order - PAGE_SHIFT)
> >>
> >> Yes. And shame on me for missing it (this time!) at review.
> >>
> >> There's still time to fix this. Patches, please.
> >
> > Here it is. Made at 3.30 AM, build tested only.
>
> Prefer on top of Maddy's patch which makes it always a variable, rather
> than CONFIG_DEBUG_FS. It's got enough hair as it is.
>
We're at 3.15-rc5 and this interface should be finalised for 3.16. So
Kirrill's patch is pretty urgent and should come first.
Well. It's only a debugfs interface at this stage so we are allowed to
change it later, but it's better not to.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org,
benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com,
mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org,
mingo@kernel.org, dave.hansen@intel.com
Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc
Date: Tue, 20 May 2014 00:32:01 -0700 [thread overview]
Message-ID: <20140520003201.a2360d5d.akpm@linux-foundation.org> (raw)
Message-ID: <20140520073201.qxtJQ2dlNRVdqYZDS7X-jhM_IbwXYn4uGIxWND87uOA@z> (raw)
In-Reply-To: <87oaythsvk.fsf@rustcorp.com.au>
On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> > Andrew Morton wrote:
> >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> >>
> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be
> >> > the order of the fault-around size in bytes, and fault_around_pages()
> >> > use 1UL << (fault_around_order - PAGE_SHIFT)
> >>
> >> Yes. And shame on me for missing it (this time!) at review.
> >>
> >> There's still time to fix this. Patches, please.
> >
> > Here it is. Made at 3.30 AM, build tested only.
>
> Prefer on top of Maddy's patch which makes it always a variable, rather
> than CONFIG_DEBUG_FS. It's got enough hair as it is.
>
We're at 3.15-rc5 and this interface should be finalised for 3.16. So
Kirrill's patch is pretty urgent and should come first.
Well. It's only a debugfs interface at this stage so we are allowed to
change it later, but it's better not to.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-arch@vger.kernel.org, riel@redhat.com,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
dave.hansen@intel.com, peterz@infradead.org, x86@kernel.org,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ak@linux.intel.com, paulus@samba.org, mgorman@suse.de,
linuxppc-dev@lists.ozlabs.org, mingo@kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc
Date: Tue, 20 May 2014 00:32:01 -0700 [thread overview]
Message-ID: <20140520003201.a2360d5d.akpm@linux-foundation.org> (raw)
In-Reply-To: <87oaythsvk.fsf@rustcorp.com.au>
On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> > Andrew Morton wrote:
> >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> >>
> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be
> >> > the order of the fault-around size in bytes, and fault_around_pages()
> >> > use 1UL << (fault_around_order - PAGE_SHIFT)
> >>
> >> Yes. And shame on me for missing it (this time!) at review.
> >>
> >> There's still time to fix this. Patches, please.
> >
> > Here it is. Made at 3.30 AM, build tested only.
>
> Prefer on top of Maddy's patch which makes it always a variable, rather
> than CONFIG_DEBUG_FS. It's got enough hair as it is.
>
We're at 3.15-rc5 and this interface should be finalised for 3.16. So
Kirrill's patch is pretty urgent and should come first.
Well. It's only a debugfs interface at this stage so we are allowed to
change it later, but it's better not to.
next prev parent reply other threads:[~2014-05-20 7:32 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 9:28 [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 1/2] mm: move FAULT_AROUND_ORDER to arch/ Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-08 9:28 ` Madhavan Srinivasan
2014-05-20 7:28 ` Andrew Morton
2014-05-20 7:28 ` Andrew Morton
2014-05-20 7:28 ` Andrew Morton
2014-05-20 8:03 ` Madhavan Srinivasan
2014-05-20 8:03 ` Madhavan Srinivasan
2014-05-20 8:03 ` Madhavan Srinivasan
2014-05-20 8:03 ` Madhavan Srinivasan
2014-05-15 8:25 ` [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-15 8:25 ` Madhavan Srinivasan
2014-05-15 8:25 ` Madhavan Srinivasan
2014-05-15 17:28 ` Hugh Dickins
2014-05-15 17:28 ` Hugh Dickins
2014-05-15 17:28 ` Hugh Dickins
2014-05-19 0:12 ` Rusty Russell
2014-05-19 0:12 ` Rusty Russell
2014-05-19 0:12 ` Rusty Russell
2014-05-19 3:05 ` Madhavan Srinivasan
2014-05-19 3:05 ` Madhavan Srinivasan
2014-05-19 3:05 ` Madhavan Srinivasan
2014-05-19 23:23 ` Hugh Dickins
2014-05-19 23:23 ` Hugh Dickins
2014-05-19 23:23 ` Hugh Dickins
2014-05-19 23:43 ` Andrew Morton
2014-05-19 23:43 ` Andrew Morton
2014-05-19 23:43 ` Andrew Morton
2014-05-19 23:43 ` Andrew Morton
2014-05-20 0:44 ` Kirill A. Shutemov
2014-05-20 0:44 ` Kirill A. Shutemov
2014-05-20 0:44 ` Kirill A. Shutemov
2014-05-20 6:22 ` Rusty Russell
2014-05-20 6:22 ` Rusty Russell
2014-05-20 6:22 ` Rusty Russell
2014-05-20 6:22 ` Rusty Russell
2014-05-20 6:22 ` Rusty Russell
2014-05-20 7:32 ` Andrew Morton [this message]
2014-05-20 7:32 ` Andrew Morton
2014-05-20 7:32 ` Andrew Morton
2014-05-20 7:53 ` Madhavan Srinivasan
2014-05-20 7:53 ` Madhavan Srinivasan
2014-05-20 7:53 ` Madhavan Srinivasan
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 19:59 ` Andrew Morton
2014-05-20 19:59 ` Andrew Morton
2014-05-20 19:59 ` Andrew Morton
2014-05-21 13:40 ` Kirill A. Shutemov
2014-05-21 13:40 ` Kirill A. Shutemov
2014-05-21 13:40 ` Kirill A. Shutemov
2014-05-21 20:34 ` Andrew Morton
2014-05-21 20:34 ` Andrew Morton
2014-05-21 20:34 ` Andrew Morton
2014-05-23 12:28 ` Kirill A. Shutemov
2014-05-23 12:28 ` Kirill A. Shutemov
2014-05-23 12:28 ` Kirill A. Shutemov
2014-05-27 6:24 ` Madhavan Srinivasan
2014-05-27 6:24 ` Madhavan Srinivasan
2014-05-27 6:24 ` Madhavan Srinivasan
2014-05-27 10:21 ` Kirill A. Shutemov
2014-05-27 10:21 ` Kirill A. Shutemov
2014-05-27 10:21 ` Kirill A. Shutemov
2014-05-27 10:44 ` Madhavan Srinivasan
2014-05-27 10:44 ` Madhavan Srinivasan
2014-05-27 10:44 ` Madhavan Srinivasan
2014-05-20 1:14 ` Rusty Russell
2014-05-20 1:14 ` Rusty Russell
2014-05-20 1:14 ` Rusty Russell
2014-05-20 1:14 ` Rusty Russell
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:06 ` Madhavan Srinivasan
2014-05-20 2:06 ` Madhavan Srinivasan
2014-05-20 2:06 ` Madhavan Srinivasan
2014-05-20 2:06 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520003201.a2360d5d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.