From: Tony Lindgren <tony@atomide.com>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: OMAP2+: Remove suspend_set_ops from common pm late init
Date: Mon, 19 May 2014 17:34:42 -0700 [thread overview]
Message-ID: <20140520003442.GC15793@atomide.com> (raw)
In-Reply-To: <1399919601-15543-1-git-send-email-d-gerlach@ti.com>
* Dave Gerlach <d-gerlach@ti.com> [140512 11:34]:
> In omap2_common_pm_late_init suspend_set_ops was called to set common
> suspend handling functions for all omap platforms. This created two
> problems. First, these suspend ops were being set for all platforms,
> regardless of whether or not suspend support has been integrated so in
> the case of AM33XX, suspend to mem was presented as available but
> failed every time. Second, some platforms will need to define a
> completely separate set of suspend ops, such as AM33XX, due to
> differences from previous omap platforms so there is no need to
> always set the common omap ops.
>
> This patch moves the suspend_set_ops call from omap2_common_pm_late_init
> into a separate function that then gets called in the omap*_pm_init
> functions for each platform.
Gets rid of some ifdefs too. Applying into omap-for-v3.16/soc
thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP2+: Remove suspend_set_ops from common pm late init
Date: Mon, 19 May 2014 17:34:42 -0700 [thread overview]
Message-ID: <20140520003442.GC15793@atomide.com> (raw)
In-Reply-To: <1399919601-15543-1-git-send-email-d-gerlach@ti.com>
* Dave Gerlach <d-gerlach@ti.com> [140512 11:34]:
> In omap2_common_pm_late_init suspend_set_ops was called to set common
> suspend handling functions for all omap platforms. This created two
> problems. First, these suspend ops were being set for all platforms,
> regardless of whether or not suspend support has been integrated so in
> the case of AM33XX, suspend to mem was presented as available but
> failed every time. Second, some platforms will need to define a
> completely separate set of suspend ops, such as AM33XX, due to
> differences from previous omap platforms so there is no need to
> always set the common omap ops.
>
> This patch moves the suspend_set_ops call from omap2_common_pm_late_init
> into a separate function that then gets called in the omap*_pm_init
> functions for each platform.
Gets rid of some ifdefs too. Applying into omap-for-v3.16/soc
thanks.
Tony
next prev parent reply other threads:[~2014-05-20 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 18:33 [PATCH v2] ARM: OMAP2+: Remove suspend_set_ops from common pm late init Dave Gerlach
2014-05-12 18:33 ` Dave Gerlach
2014-05-20 0:34 ` Tony Lindgren [this message]
2014-05-20 0:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520003442.GC15793@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.