All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: riel@redhat.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	kosaki.motohiro@jp.fujitsu.com, fengguang.wu@intel.com,
	kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list().
Date: Tue, 20 May 2014 15:24:52 +1000	[thread overview]
Message-ID: <20140520052452.GG18954@dastard> (raw)
In-Reply-To: <201405200354.s4K3sTUx057458@www262.sakura.ne.jp>

On Tue, May 20, 2014 at 12:54:29PM +0900, Tetsuo Handa wrote:
> Dave Chinner wrote:
> > So, XFS should be passing kswapd context to the workqueue allocation
> > context. The patch below does this.
> > 
> > Tetsuo-san, when it comes to problems involving XFS, you should
> > really CC xfs@oss.sgi.com because very few people really know how
> > XFS works and even fewer still know how it is supposed to interact
> > with memory reclaim....
> 
> Thank you for the patch, but ...
> 
>   #define PF_KSWAPD       0x00040000      /* I am kswapd */
> 
>   static inline int current_is_kswapd(void)
>   {
>   	return current->flags & PF_KSWAPD;
>   }

> I think ((char) (current->flags & 0x00040000)) == 0.
> Your patch wants
> 
>   -args->kswapd = current_is_kswapd();
>   +args->kswapd = (current_is_kswapd() != 0);

Thanks for pointing that out, but I think:

-static inline int current_is_kswapd(void)
+static inline bool current_is_kswapd(void)

is a better solution. It can only be true or false.

But regardless, I need to change the boolean options in that XFS
structure to be, well, booleans.

Cheers,

dave.

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: riel@redhat.com, kosaki.motohiro@jp.fujitsu.com,
	fengguang.wu@intel.com, kamezawa.hiroyu@jp.fujitsu.com,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list().
Date: Tue, 20 May 2014 15:24:52 +1000	[thread overview]
Message-ID: <20140520052452.GG18954@dastard> (raw)
In-Reply-To: <201405200354.s4K3sTUx057458@www262.sakura.ne.jp>

On Tue, May 20, 2014 at 12:54:29PM +0900, Tetsuo Handa wrote:
> Dave Chinner wrote:
> > So, XFS should be passing kswapd context to the workqueue allocation
> > context. The patch below does this.
> > 
> > Tetsuo-san, when it comes to problems involving XFS, you should
> > really CC xfs@oss.sgi.com because very few people really know how
> > XFS works and even fewer still know how it is supposed to interact
> > with memory reclaim....
> 
> Thank you for the patch, but ...
> 
>   #define PF_KSWAPD       0x00040000      /* I am kswapd */
> 
>   static inline int current_is_kswapd(void)
>   {
>   	return current->flags & PF_KSWAPD;
>   }

> I think ((char) (current->flags & 0x00040000)) == 0.
> Your patch wants
> 
>   -args->kswapd = current_is_kswapd();
>   +args->kswapd = (current_is_kswapd() != 0);

Thanks for pointing that out, but I think:

-static inline int current_is_kswapd(void)
+static inline bool current_is_kswapd(void)

is a better solution. It can only be true or false.

But regardless, I need to change the boolean options in that XFS
structure to be, well, booleans.

Cheers,

dave.

-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2014-05-20  5:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 14:40 [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list() Tetsuo Handa
2014-05-19 17:42 ` Rik van Riel
2014-05-20  0:44 ` Dave Chinner
2014-05-20  0:44   ` Dave Chinner
2014-05-20  3:54   ` Tetsuo Handa
2014-05-20  3:54     ` Tetsuo Handa
2014-05-20  5:24     ` Dave Chinner [this message]
2014-05-20  5:24       ` Dave Chinner
2014-05-20  5:59   ` Andrew Morton
2014-05-20  5:59     ` Andrew Morton
2014-05-20  6:03     ` Andrew Morton
2014-05-20  6:03       ` Andrew Morton
2014-05-20  6:33       ` Dave Chinner
2014-05-20  6:33         ` Dave Chinner
2014-05-20  6:30     ` Dave Chinner
2014-05-20  6:30       ` Dave Chinner
2014-05-20 14:58       ` Tetsuo Handa
2014-05-20 14:58         ` Tetsuo Handa
2014-05-20 16:12         ` Motohiro Kosaki
2014-05-20 16:12           ` Motohiro Kosaki
2014-05-26 11:45           ` [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list() Tetsuo Handa
2014-05-26 11:45             ` Tetsuo Handa
2014-06-03 21:43             ` David Rientjes
2014-06-03 21:43               ` David Rientjes
2014-06-05 12:45               ` [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list() Tetsuo Handa
2014-06-05 12:45                 ` Tetsuo Handa
2014-06-05 13:17                 ` Dave Chinner
2014-06-05 13:17                   ` Dave Chinner
2014-06-06 12:19                   ` [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list() Tetsuo Handa
2014-06-06 12:19                     ` Tetsuo Handa
2014-06-09 11:53                 ` [PATCH] mm/vmscan: Do not block forever at shrink_inactive_list() Tetsuo Handa
2014-06-09 11:53                   ` Tetsuo Handa
2014-07-02 12:40                   ` Tetsuo Handa
2014-05-20  7:20     ` Christoph Hellwig
2014-05-20  7:20       ` Christoph Hellwig
2014-05-20  2:35 ` Jianyu Zhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520052452.GG18954@dastard \
    --to=david@fromorbit.com \
    --cc=fengguang.wu@intel.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=riel@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.