From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/8] staging: r8712u: Remove useless return variables
Date: Tue, 20 May 2014 11:41:13 +0000 [thread overview]
Message-ID: <20140520114113.GG15585@mwanda> (raw)
In-Reply-To: <537B38FF.4050106@bfs.de>
Those concerns are valid but the code was like that in the original so
we should merge this patch as is and hope some volunteer will fix things
up in a follow on patch.
Fixing them in this patch would be a mistake anyway because of the one
thing per patch rule.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/8] staging: r8712u: Remove useless return variables
Date: Tue, 20 May 2014 14:41:13 +0300 [thread overview]
Message-ID: <20140520114113.GG15585@mwanda> (raw)
In-Reply-To: <537B38FF.4050106@bfs.de>
Those concerns are valid but the code was like that in the original so
we should merge this patch as is and hope some volunteer will fix things
up in a follow on patch.
Fixing them in this patch would be a mistake anyway because of the one
thing per patch rule.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-20 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 10:33 [PATCH 1/8] staging: r8712u: Remove useless return variables Peter Senna Tschudin
2014-05-20 10:33 ` Peter Senna Tschudin
2014-05-20 11:14 ` walter harms
2014-05-20 11:14 ` walter harms
2014-05-20 11:41 ` Dan Carpenter [this message]
2014-05-20 11:41 ` Dan Carpenter
2014-05-20 12:52 ` walter harms
2014-05-20 12:52 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520114113.GG15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.