From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
Date: Tue, 20 May 2014 16:20:54 +0100 [thread overview]
Message-ID: <20140520152054.GB24991@lee--X1> (raw)
In-Reply-To: <536E1543.3090107@aurabindo.in>
> From 95f6ac368dbe352af0dfa2097b7d58b416447be5 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@aurabindo.in>
> Date: Sat, 10 May 2014 15:16:58 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning.
>
> drivers/mfd/abx500-core.c: In function ?abx500_dump_all_banks?:
> drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
> is larger than 1024 bytes [-Wframe-larger-than=]
>
> Signed-off-by: Aurabindo J <mail@aurabindo.in>
> ---
> drivers/mfd/abx500-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Looks good to me. I'll apply it until Linus complains.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Jay Aurabind <mail@aurabindo.in>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Trivial Monkey <trivial@rustcorp.com.au>
Subject: Re: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
Date: Tue, 20 May 2014 16:20:54 +0100 [thread overview]
Message-ID: <20140520152054.GB24991@lee--X1> (raw)
In-Reply-To: <536E1543.3090107@aurabindo.in>
> From 95f6ac368dbe352af0dfa2097b7d58b416447be5 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@aurabindo.in>
> Date: Sat, 10 May 2014 15:16:58 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning.
>
> drivers/mfd/abx500-core.c: In function ‘abx500_dump_all_banks’:
> drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
> is larger than 1024 bytes [-Wframe-larger-than=]
>
> Signed-off-by: Aurabindo J <mail@aurabindo.in>
> ---
> drivers/mfd/abx500-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Looks good to me. I'll apply it until Linus complains.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-20 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 12:02 [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame Jay Aurabind
2014-05-10 12:02 ` Jay Aurabind
2014-05-20 15:20 ` Lee Jones [this message]
2014-05-20 15:20 ` Lee Jones
2014-05-21 6:15 ` [PATCH V2] " Jay Aurabind
2014-05-21 6:15 ` Jay Aurabind
2014-05-21 9:17 ` Lee Jones
2014-05-21 9:17 ` Lee Jones
2014-05-21 17:19 ` Jay Aurabind
2014-05-21 17:19 ` Jay Aurabind
2014-05-22 8:42 ` Lee Jones
2014-05-22 8:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520152054.GB24991@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.