All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "aik@ozlabs.ru" <aik@ozlabs.ru>, Alexander Graf <agraf@suse.de>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	Gavin Shan <gwshan@linux.vnet.ibm.com>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"qiudayu@linux.vnet.ibm.com" <qiudayu@linux.vnet.ibm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO
Date: Wed, 21 May 2014 10:48:52 +0000	[thread overview]
Message-ID: <20140521104852.GA20297@shangw> (raw)
In-Reply-To: <1400657062.18653.2.camel@pasglop>

On Wed, May 21, 2014 at 05:24:22PM +1000, Benjamin Herrenschmidt wrote:
>On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote:
>> > Note to Alex: This definitely kills the notifier idea for now
>> though,
>> > at least as a first class citizen of the design. We can add it as an
>> > optional optimization on top later.
>> 
>> I don't think it does. The notifier would just get triggered on config
>> space read failures for example :). It's really just an aid for the
>> vfio user to have a common code path for error handling.
>
>I'll let Gavin make the final call on that one, if he thinks we can
>reliably trigger it and there isn't too much code churn as a
>consequence.
>

Lets postpone it as future improvement. It's not hard to send the
event (EEH errors) out, but I need think about how to extend the
existing guest's infrastructure to accept event. As Ben mentioned,
event-scan might be potential mechanism for that. We can discuss
for more later :-)

Thanks,
Gavin


WARNING: multiple messages have this Message-ID (diff)
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "aik@ozlabs.ru" <aik@ozlabs.ru>, Alexander Graf <agraf@suse.de>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	Gavin Shan <gwshan@linux.vnet.ibm.com>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"qiudayu@linux.vnet.ibm.com" <qiudayu@linux.vnet.ibm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO
Date: Wed, 21 May 2014 20:48:52 +1000	[thread overview]
Message-ID: <20140521104852.GA20297@shangw> (raw)
In-Reply-To: <1400657062.18653.2.camel@pasglop>

On Wed, May 21, 2014 at 05:24:22PM +1000, Benjamin Herrenschmidt wrote:
>On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote:
>> > Note to Alex: This definitely kills the notifier idea for now
>> though,
>> > at least as a first class citizen of the design. We can add it as an
>> > optional optimization on top later.
>> 
>> I don't think it does. The notifier would just get triggered on config
>> space read failures for example :). It's really just an aid for the
>> vfio user to have a common code path for error handling.
>
>I'll let Gavin make the final call on that one, if he thinks we can
>reliably trigger it and there isn't too much code churn as a
>consequence.
>

Lets postpone it as future improvement. It's not hard to send the
event (EEH errors) out, but I need think about how to extend the
existing guest's infrastructure to accept event. As Ben mentioned,
event-scan might be potential mechanism for that. We can discuss
for more later :-)

Thanks,
Gavin

  reply	other threads:[~2014-05-21 10:48 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  8:30 [PATCH RFCv4 0/4] EEH Support for VFIO PCI device Gavin Shan
2014-05-20  8:30 ` Gavin Shan
2014-05-20  8:30 ` [PATCH 1/4] drivers/vfio: Introduce CONFIG_VFIO_PCI_EEH Gavin Shan
2014-05-20  8:30   ` Gavin Shan
2014-05-20  8:30 ` [PATCH 2/4] powerpc/eeh: Flags for passed device and PE Gavin Shan
2014-05-20  8:30   ` Gavin Shan
2014-05-20  8:30 ` [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-20  8:30   ` Gavin Shan
2014-05-20 11:21   ` Alexander Graf
2014-05-20 11:21     ` Alexander Graf
2014-05-20 11:28     ` Alexander Graf
2014-05-20 11:28       ` Alexander Graf
2014-05-20 11:40       ` Gavin Shan
2014-05-20 11:40         ` Gavin Shan
2014-05-20 11:44         ` Alexander Graf
2014-05-20 11:44           ` Alexander Graf
2014-05-20 12:21           ` Gavin Shan
2014-05-20 12:21             ` Gavin Shan
2014-05-20 12:25             ` Alexander Graf
2014-05-20 12:25               ` Alexander Graf
2014-05-20 12:39               ` Gavin Shan
2014-05-20 12:39                 ` Gavin Shan
2014-05-21  0:23                 ` Benjamin Herrenschmidt
2014-05-21  0:23                   ` Benjamin Herrenschmidt
2014-05-21  4:39                   ` Gavin Shan
2014-05-21  4:39                     ` Gavin Shan
2014-05-21  6:23                   ` Alexander Graf
2014-05-21  6:23                     ` Alexander Graf
2014-05-21  7:24                     ` Benjamin Herrenschmidt
2014-05-21  7:24                       ` Benjamin Herrenschmidt
2014-05-21 10:48                       ` Gavin Shan [this message]
2014-05-21 10:48                         ` Gavin Shan
2014-05-21  0:21               ` Benjamin Herrenschmidt
2014-05-21  0:21                 ` Benjamin Herrenschmidt
2014-05-20  8:30 ` [PATCH 4/4] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-20  8:30   ` Gavin Shan
2014-05-20 11:25   ` Alexander Graf
2014-05-20 11:25     ` Alexander Graf
2014-05-20 11:56     ` Gavin Shan
2014-05-20 11:56       ` Gavin Shan
2014-05-20 12:14       ` Alexander Graf
2014-05-20 12:14         ` Alexander Graf
2014-05-20 12:45         ` Gavin Shan
2014-05-20 12:45           ` Gavin Shan
2014-05-20 13:49           ` Alexander Graf
2014-05-20 13:49             ` Alexander Graf
2014-05-21  0:13             ` Benjamin Herrenschmidt
2014-05-21  0:13               ` Benjamin Herrenschmidt
2014-05-21  6:16               ` Alexander Graf
2014-05-21  6:16                 ` Alexander Graf
2014-05-21  0:19             ` Benjamin Herrenschmidt
2014-05-21  0:19               ` Benjamin Herrenschmidt
2014-05-21  6:20               ` Alexander Graf
2014-05-21  6:20                 ` Alexander Graf
2014-05-21  0:12       ` Benjamin Herrenschmidt
2014-05-21  0:12         ` Benjamin Herrenschmidt
2014-05-21  4:41         ` Gavin Shan
2014-05-21  4:41           ` Gavin Shan
2014-06-03  5:54     ` Paul Mackerras
2014-06-03  5:54       ` Paul Mackerras
2014-06-03  7:45       ` Alexander Graf
2014-06-03  7:45         ` Alexander Graf
2014-06-03  7:52         ` Benjamin Herrenschmidt
2014-06-03  7:52           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521104852.GA20297@shangw \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=qiudayu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.