From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...)
Date: Wed, 21 May 2014 13:41:58 +0000 [thread overview]
Message-ID: <20140521134158.GB4719@vaio> (raw)
In-Reply-To: <20140520200827.GM15585@mwanda>
On Tue, May 20, 2014 at 11:08:27PM +0300, Dan Carpenter wrote:
> On Tue, May 20, 2014 at 03:41:13PM +0100, Giedrius Rekasius wrote:
> > From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
> >
> > Remove unused local variable "store" from ext4_readdir(...)
> >
> > Local variable "stored" is initialized however never used inside the function.
> >
> > Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
>
> You email client is corrupting the patch so it doesn't apply.
>
> Read Documentation/email-clients.txt (linux-next version).
Indeed the patch was corrupt, my apologies for that. Patch resubmission
below.
From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Remove unused local variable "store" from ext4_readdir(...)
Local variable "stored" is initialized however never used inside the function.
Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
---
fs/ext4/dir.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index d638c57..ef1bed6 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -105,7 +105,7 @@ int __ext4_check_dir_entry(const char *function, unsigned int line,
static int ext4_readdir(struct file *file, struct dir_context *ctx)
{
unsigned int offset;
- int i, stored;
+ int i;
struct ext4_dir_entry_2 *de;
int err;
struct inode *inode = file_inode(file);
@@ -133,7 +133,6 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx)
return ret;
}
- stored = 0;
offset = ctx->pos & (sb->s_blocksize - 1);
while (ctx->pos < inode->i_size) {
WARNING: multiple messages have this Message-ID (diff)
From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...)
Date: Wed, 21 May 2014 14:41:58 +0100 [thread overview]
Message-ID: <20140521134158.GB4719@vaio> (raw)
In-Reply-To: <20140520200827.GM15585@mwanda>
On Tue, May 20, 2014 at 11:08:27PM +0300, Dan Carpenter wrote:
> On Tue, May 20, 2014 at 03:41:13PM +0100, Giedrius Rekasius wrote:
> > From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
> >
> > Remove unused local variable "store" from ext4_readdir(...)
> >
> > Local variable "stored" is initialized however never used inside the function.
> >
> > Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
>
> You email client is corrupting the patch so it doesn't apply.
>
> Read Documentation/email-clients.txt (linux-next version).
Indeed the patch was corrupt, my apologies for that. Patch resubmission
below.
From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Remove unused local variable "store" from ext4_readdir(...)
Local variable "stored" is initialized however never used inside the function.
Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
---
fs/ext4/dir.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index d638c57..ef1bed6 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -105,7 +105,7 @@ int __ext4_check_dir_entry(const char *function, unsigned int line,
static int ext4_readdir(struct file *file, struct dir_context *ctx)
{
unsigned int offset;
- int i, stored;
+ int i;
struct ext4_dir_entry_2 *de;
int err;
struct inode *inode = file_inode(file);
@@ -133,7 +133,6 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx)
return ret;
}
- stored = 0;
offset = ctx->pos & (sb->s_blocksize - 1);
while (ctx->pos < inode->i_size) {
next prev parent reply other threads:[~2014-05-21 13:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 14:41 [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...) Giedrius Rekasius
2014-05-20 14:41 ` Giedrius Rekasius
2014-05-20 20:08 ` Dan Carpenter
2014-05-20 20:08 ` Dan Carpenter
2014-05-21 13:41 ` Giedrius Rekasius [this message]
2014-05-21 13:41 ` Giedrius Rekasius
2014-05-21 13:51 ` Dan Carpenter
2014-05-21 13:51 ` Dan Carpenter
2014-05-21 15:16 ` Giedrius Rekasius
2014-05-21 15:16 ` Giedrius Rekasius
2014-05-21 15:32 ` [PATCH] ext4: remove unused local variable "stored" " Giedrius Rekasius
2014-05-21 15:32 ` Giedrius Rekasius
2014-05-21 17:44 ` Dan Carpenter
2014-05-21 17:44 ` Dan Carpenter
2014-05-26 16:34 ` Theodore Ts'o
2014-05-26 16:34 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521134158.GB4719@vaio \
--to=giedrius.rekasius@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.