All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: lkp@lists.01.org
Subject: Re: [x86, vdso] cfda7bb9ecb: +14.7% will-it-scale.per_thread_ops
Date: Thu, 22 May 2014 09:54:48 +0800	[thread overview]
Message-ID: <20140522015448.GA23196@localhost> (raw)
In-Reply-To: <CALCETrVFbo1yb7FyCH1Y=pHb89VPt9ycx0C-wv2A7h=CzwwdGA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

Hi Andy,

On Wed, May 21, 2014 at 03:46:58PM -0700, Andy Lutomirski wrote:
> On Mon, May 19, 2014 at 10:59 PM, Jet Chen <jet.chen@intel.com> wrote:
> > Hi Andy,
> >
> > FYI, we noticed the below changes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vdso
> > commit cfda7bb9ecbf9d96264bb5bade33a842966d1062 ("x86, vdso: Move syscall
> > and sysenter setup into kernel/cpu/common.c")
> 
> This is really strange.  That change shouldn't have any effect except
> that some kernels might boot a cycle or two faster.
> 
> >
> > test case: nhm4/will-it-scale/sched_yield
> >
> > 3d7ee969bffcc98  cfda7bb9ecbf9d96264bb5bad
> > ---------------  -------------------------
> >     5497021 ~ 0%     +14.7%    6303424 ~ 0%  TOTAL
> > will-it-scale.per_thread_ops
> >        0.54 ~ 0%      +5.6%       0.57 ~ 0%  TOTAL will-it-scale.scalability
> >     6209483 ~ 0%      +1.6%    6305917 ~ 0%  TOTAL
> > will-it-scale.per_process_ops
> >        2455 ~ 5%     +16.9%       2870 ~ 5%  TOTAL cpuidle.C1-NHM.usage
> >        8829 ~ 7%     +15.2%      10169 ~10%  TOTAL
> > slabinfo.kmalloc-64.active_objs
> >       24.13 ~12%     +48.9%      35.93 ~14%  TOTAL time.user_time
> >         393 ~ 0%      -3.0%        382 ~ 1%  TOTAL time.system_time
> >
> 
> Is this a speedup or a slowdown?

It's a speedup. The will-it-scale/sched_yield test case's throughput
increased by +14.7% (multi-thread case) and +1.6% (multi-process case).

However the CPU %user time increased more, by +48.9%.

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jet Chen <jet.chen@intel.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [x86, vdso] cfda7bb9ecb: +14.7% will-it-scale.per_thread_ops
Date: Thu, 22 May 2014 09:54:48 +0800	[thread overview]
Message-ID: <20140522015448.GA23196@localhost> (raw)
In-Reply-To: <CALCETrVFbo1yb7FyCH1Y=pHb89VPt9ycx0C-wv2A7h=CzwwdGA@mail.gmail.com>

Hi Andy,

On Wed, May 21, 2014 at 03:46:58PM -0700, Andy Lutomirski wrote:
> On Mon, May 19, 2014 at 10:59 PM, Jet Chen <jet.chen@intel.com> wrote:
> > Hi Andy,
> >
> > FYI, we noticed the below changes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vdso
> > commit cfda7bb9ecbf9d96264bb5bade33a842966d1062 ("x86, vdso: Move syscall
> > and sysenter setup into kernel/cpu/common.c")
> 
> This is really strange.  That change shouldn't have any effect except
> that some kernels might boot a cycle or two faster.
> 
> >
> > test case: nhm4/will-it-scale/sched_yield
> >
> > 3d7ee969bffcc98  cfda7bb9ecbf9d96264bb5bad
> > ---------------  -------------------------
> >     5497021 ~ 0%     +14.7%    6303424 ~ 0%  TOTAL
> > will-it-scale.per_thread_ops
> >        0.54 ~ 0%      +5.6%       0.57 ~ 0%  TOTAL will-it-scale.scalability
> >     6209483 ~ 0%      +1.6%    6305917 ~ 0%  TOTAL
> > will-it-scale.per_process_ops
> >        2455 ~ 5%     +16.9%       2870 ~ 5%  TOTAL cpuidle.C1-NHM.usage
> >        8829 ~ 7%     +15.2%      10169 ~10%  TOTAL
> > slabinfo.kmalloc-64.active_objs
> >       24.13 ~12%     +48.9%      35.93 ~14%  TOTAL time.user_time
> >         393 ~ 0%      -3.0%        382 ~ 1%  TOTAL time.system_time
> >
> 
> Is this a speedup or a slowdown?

It's a speedup. The will-it-scale/sched_yield test case's throughput
increased by +14.7% (multi-thread case) and +1.6% (multi-process case).

However the CPU %user time increased more, by +48.9%.

Thanks,
Fengguang

  reply	other threads:[~2014-05-22  1:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  5:59 [x86, vdso] cfda7bb9ecb: +14.7% will-it-scale.per_thread_ops Jet Chen
2014-05-20  5:59 ` Jet Chen
2014-05-21 22:46 ` Andy Lutomirski
2014-05-21 22:46   ` Andy Lutomirski
2014-05-22  1:54   ` Fengguang Wu [this message]
2014-05-22  1:54     ` Fengguang Wu
2014-05-22  5:03     ` H. Peter Anvin
2014-05-22  5:03       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522015448.GA23196@localhost \
    --to=fengguang.wu@intel.com \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.