All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v5 3/7] mfd: ti-keystone-devctrl: add bindings for device state control
Date: Thu, 22 May 2014 15:14:32 +0100	[thread overview]
Message-ID: <20140522141432.GA19747@lee--X1> (raw)
In-Reply-To: <1400766516-14537-4-git-send-email-ivan.khoronzhuk@ti.com>

Why do I only have this patch?  Where is the rest of the set?  Also,
it's on v5 and I don't recall seeing the other 4 versions?

> The Keystone II devices have a set of registers that are used to control
> the status of its peripherals. This node is intended to allow access to
> this functionality.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti-keystone-devctrl.txt   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> new file mode 100644
> index 0000000..35f7a66
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> @@ -0,0 +1,19 @@
> +* Device tree bindings for Texas Instruments keystone device state control
> +
> +The Keystone II devices have a set of registers that are used to control
> +the status of its peripherals. This node is intended to allow access to
> +this functionality.
> +
> +Required properties:
> +
> +- compatible:		"ti,keystone-devctrl", "syscon"
> +
> +- reg:			contains offset/length value for pll controller
> +			registers space.

Why have you tabbed out all that way?

> +Example:
> +
> +devctrl: device-state-control {

This node needs an address:

devctrl: device-state-control at 02620000 {

> +	compatible = "ti,keystone-devctrl", "syscon";
> +	reg = <0x02620000 0x1000>;
> +};

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org,
	santosh.shilimkar@ti.com, arnd@arndb.de, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	grant.likely@linaro.org, devicetree@vger.kernel.org,
	grygorii.strashko@ti.com, linux@arm.linux.org.uk,
	sergei.shtylyov@cogentembedded.com, linux-doc@vger.kernel.org,
	w-kwok2@ti.com, rdunlap@infradead.org, sboyd@codeaurora.org,
	linux-kernel@vger.kernel.org, m-karicheri2@ti.com,
	olof@lixom.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch v5 3/7] mfd: ti-keystone-devctrl: add bindings for device state control
Date: Thu, 22 May 2014 15:14:32 +0100	[thread overview]
Message-ID: <20140522141432.GA19747@lee--X1> (raw)
In-Reply-To: <1400766516-14537-4-git-send-email-ivan.khoronzhuk@ti.com>

Why do I only have this patch?  Where is the rest of the set?  Also,
it's on v5 and I don't recall seeing the other 4 versions?

> The Keystone II devices have a set of registers that are used to control
> the status of its peripherals. This node is intended to allow access to
> this functionality.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti-keystone-devctrl.txt   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> new file mode 100644
> index 0000000..35f7a66
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
> @@ -0,0 +1,19 @@
> +* Device tree bindings for Texas Instruments keystone device state control
> +
> +The Keystone II devices have a set of registers that are used to control
> +the status of its peripherals. This node is intended to allow access to
> +this functionality.
> +
> +Required properties:
> +
> +- compatible:		"ti,keystone-devctrl", "syscon"
> +
> +- reg:			contains offset/length value for pll controller
> +			registers space.

Why have you tabbed out all that way?

> +Example:
> +
> +devctrl: device-state-control {

This node needs an address:

devctrl: device-state-control@02620000 {

> +	compatible = "ti,keystone-devctrl", "syscon";
> +	reg = <0x02620000 0x1000>;
> +};

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-05-22 14:14 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 13:48 [Patch v5 0/7] Introduce keystone reset driver Ivan Khoronzhuk
2014-05-22 13:48 ` Ivan Khoronzhuk
2014-05-22 13:48 ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 1/7] power: reset: keystone-reset: introduce " Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 2/7] clock: keystone-pllctrl: add bindings for keystone pll controller Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 3/7] mfd: ti-keystone-devctrl: add bindings for device state control Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 14:14   ` Lee Jones [this message]
2014-05-22 14:14     ` Lee Jones
2014-05-22 14:32     ` Ivan Khoronzhuk
2014-05-22 14:32       ` Ivan Khoronzhuk
2014-05-22 14:32       ` Ivan Khoronzhuk
2014-05-22 15:33       ` Lee Jones
2014-05-22 15:33         ` Lee Jones
2014-05-22 16:14         ` Ivan Khoronzhuk
2014-05-22 16:14           ` Ivan Khoronzhuk
2014-05-22 16:14           ` Ivan Khoronzhuk
2014-05-22 16:30           ` Ivan Khoronzhuk
2014-05-22 16:30             ` Ivan Khoronzhuk
2014-05-22 16:30             ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 4/7] power: reset: add bindings for keystone reset driver Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 5/7] ARM: keystone: remove redundant reset stuff Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 6/7] ARM: dts: keystone: update reset node to work with reset driver Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48 ` [Patch v5 7/7] ARM: keystone: enable reset driver support Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:48   ` Ivan Khoronzhuk
2014-05-22 13:52 ` [Patch v5 0/7] Introduce keystone reset driver Santosh Shilimkar
2014-05-22 13:52   ` Santosh Shilimkar
2014-05-22 13:52   ` Santosh Shilimkar
2014-05-22 13:54   ` Arnd Bergmann
2014-05-22 13:54     ` Arnd Bergmann
2014-05-22 13:58     ` Ivan Khoronzhuk
2014-05-22 13:58       ` Ivan Khoronzhuk
2014-05-22 13:58       ` Ivan Khoronzhuk
2014-05-22 14:02     ` Santosh Shilimkar
2014-05-22 14:02       ` Santosh Shilimkar
2014-05-22 14:02       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522141432.GA19747@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.