All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it
Date: Fri, 23 May 2014 09:34:49 +1000	[thread overview]
Message-ID: <20140522233449.GN18954@dastard> (raw)
In-Reply-To: <1400775429-30015-1-git-send-email-eguan@redhat.com>

On Fri, May 23, 2014 at 12:17:09AM +0800, Eryu Guan wrote:
> Failure message of _scratch_mount is something like:
> 
> mount: mount /dev/sda5 on /mnt/scratch failed: Structure needs cleaning
> 
> not
> 
> mount: Structure needs cleaning

Evidence to the contrary:

# MKFS_OPTIONS="-b size=1024 -m crc=1"  ./check xfs/005
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test1 3.15.0-rc5-dgc+
MKFS_OPTIONS  -- -f -b size=1024 -m crc=1 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch

xfs/005 0s ... 0s
Ran: xfs/005
Passed all 1 tests

# mount /dev/vdb /mnt/scratch
mount: Structure needs cleaning
# mount -V
mount from util-linux 2.20.1 (with libblkid and selinux support)
#

So xfs/005 is correct for a relatively recent mount binary.
What version of mount are you using?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it
Date: Fri, 23 May 2014 09:34:49 +1000	[thread overview]
Message-ID: <20140522233449.GN18954@dastard> (raw)
In-Reply-To: <1400775429-30015-1-git-send-email-eguan@redhat.com>

On Fri, May 23, 2014 at 12:17:09AM +0800, Eryu Guan wrote:
> Failure message of _scratch_mount is something like:
> 
> mount: mount /dev/sda5 on /mnt/scratch failed: Structure needs cleaning
> 
> not
> 
> mount: Structure needs cleaning

Evidence to the contrary:

# MKFS_OPTIONS="-b size=1024 -m crc=1"  ./check xfs/005
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test1 3.15.0-rc5-dgc+
MKFS_OPTIONS  -- -f -b size=1024 -m crc=1 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch

xfs/005 0s ... 0s
Ran: xfs/005
Passed all 1 tests

# mount /dev/vdb /mnt/scratch
mount: Structure needs cleaning
# mount -V
mount from util-linux 2.20.1 (with libblkid and selinux support)
#

So xfs/005 is correct for a relatively recent mount binary.
What version of mount are you using?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-05-22 23:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 16:17 [PATCH] xfs/005: filter _scratch_mount output and fix golden output to match it Eryu Guan
2014-05-22 16:17 ` Eryu Guan
2014-05-22 17:06 ` Brian Foster
2014-05-22 17:06   ` Brian Foster
2014-05-22 23:34 ` Dave Chinner [this message]
2014-05-22 23:34   ` Dave Chinner
2014-05-23  3:17   ` Eryu Guan
2014-05-23  3:17     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140522233449.GN18954@dastard \
    --to=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.