* [PATCH] gdm72xx: use time_before() @ 2014-05-25 13:08 ` Manuel Schölling 0 siblings, 0 replies; 10+ messages in thread From: Manuel Schölling @ 2014-05-25 13:08 UTC (permalink / raw) To: gregkh Cc: peter.p.waskiewicz.jr, kristina.martsenko, khoroshilov, arnd, devel, linux-kernel, kernel-janitors, Manuel Schölling To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index 20539d8..9ddf8f5 100644 --- a/drivers/staging/gdm72xx/gdm_usb.c +++ b/drivers/staging/gdm72xx/gdm_usb.c @@ -730,7 +730,7 @@ static int k_mode_thread(void *arg) spin_unlock_irqrestore(&k_lock, flags2); expire = jiffies + K_WAIT_TIME; - while (jiffies < expire) + while (time_before(jiffies, expire)) schedule_timeout(K_WAIT_TIME); spin_lock_irqsave(&rx->lock, flags); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] gdm72xx: use time_before() @ 2014-05-25 13:08 ` Manuel Schölling 0 siblings, 0 replies; 10+ messages in thread From: Manuel Schölling @ 2014-05-25 13:08 UTC (permalink / raw) To: gregkh Cc: peter.p.waskiewicz.jr, kristina.martsenko, khoroshilov, arnd, devel, linux-kernel, kernel-janitors, Manuel Schölling To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index 20539d8..9ddf8f5 100644 --- a/drivers/staging/gdm72xx/gdm_usb.c +++ b/drivers/staging/gdm72xx/gdm_usb.c @@ -730,7 +730,7 @@ static int k_mode_thread(void *arg) spin_unlock_irqrestore(&k_lock, flags2); expire = jiffies + K_WAIT_TIME; - while (jiffies < expire) + while (time_before(jiffies, expire)) schedule_timeout(K_WAIT_TIME); spin_lock_irqsave(&rx->lock, flags); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() 2014-05-25 13:08 ` Manuel Schölling @ 2014-05-25 18:14 ` Greg KH -1 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2014-05-25 18:14 UTC (permalink / raw) To: Manuel Schölling Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > To be future-proof and for better readability the time comparisons are > modified to use time_before() instead of plain, error-prone math. > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > --- > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch doesn't apply, can you please refresh it against my latest tree and resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() @ 2014-05-25 18:14 ` Greg KH 0 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2014-05-25 18:14 UTC (permalink / raw) To: Manuel Schölling Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > To be future-proof and for better readability the time comparisons are > modified to use time_before() instead of plain, error-prone math. > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > --- > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch doesn't apply, can you please refresh it against my latest tree and resend? thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() 2014-05-25 18:14 ` Greg KH @ 2014-05-25 18:24 ` Manuel Schoelling -1 siblings, 0 replies; 10+ messages in thread From: Manuel Schoelling @ 2014-05-25 18:24 UTC (permalink / raw) To: Greg KH Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > To be future-proof and for better readability the time comparisons are > > modified to use time_before() instead of plain, error-prone math. > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > --- > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch doesn't apply, can you please refresh it against my latest > tree and resend? That's weird. I pulled the lastest master from Linus and rebased the patch, but no modification of my patch was required (latest commit before my patch to that file was 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). Maybe you have a more recent version than Linus? Bye, Manuel > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() @ 2014-05-25 18:24 ` Manuel Schoelling 0 siblings, 0 replies; 10+ messages in thread From: Manuel Schoelling @ 2014-05-25 18:24 UTC (permalink / raw) To: Greg KH Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > To be future-proof and for better readability the time comparisons are > > modified to use time_before() instead of plain, error-prone math. > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > --- > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch doesn't apply, can you please refresh it against my latest > tree and resend? That's weird. I pulled the lastest master from Linus and rebased the patch, but no modification of my patch was required (latest commit before my patch to that file was 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). Maybe you have a more recent version than Linus? Bye, Manuel > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() 2014-05-25 18:24 ` Manuel Schoelling @ 2014-05-25 18:33 ` Greg KH -1 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2014-05-25 18:33 UTC (permalink / raw) To: Manuel Schoelling Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > > To be future-proof and for better readability the time comparisons are > > > modified to use time_before() instead of plain, error-prone math. > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > --- > > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This patch doesn't apply, can you please refresh it against my latest > > tree and resend? > That's weird. I pulled the lastest master from Linus and rebased the > patch, but no modification of my patch was required (latest commit > before my patch to that file was > 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). > > Maybe you have a more recent version than Linus? I have a much different version from Linus, with a few thousand patches added, otherwise how would I be able to queue up stuff to go to Linus for the next kernel release? :) For the staging patches, either use the linux-next tree (which you should use for all kernel development), or my staging.git tree, and the staging-next branch on git.kernel.org, which is what gets pulled into linux-next every week-day. If you have more questions about this, take a look at Documentation/development-process/ it should explain how patches move to Linus and why working against Linus's tree isn't going to get you very far. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() @ 2014-05-25 18:33 ` Greg KH 0 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2014-05-25 18:33 UTC (permalink / raw) To: Manuel Schoelling Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > > To be future-proof and for better readability the time comparisons are > > > modified to use time_before() instead of plain, error-prone math. > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > --- > > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This patch doesn't apply, can you please refresh it against my latest > > tree and resend? > That's weird. I pulled the lastest master from Linus and rebased the > patch, but no modification of my patch was required (latest commit > before my patch to that file was > 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). > > Maybe you have a more recent version than Linus? I have a much different version from Linus, with a few thousand patches added, otherwise how would I be able to queue up stuff to go to Linus for the next kernel release? :) For the staging patches, either use the linux-next tree (which you should use for all kernel development), or my staging.git tree, and the staging-next branch on git.kernel.org, which is what gets pulled into linux-next every week-day. If you have more questions about this, take a look at Documentation/development-process/ it should explain how patches move to Linus and why working against Linus's tree isn't going to get you very far. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() 2014-05-25 18:33 ` Greg KH @ 2014-05-25 18:43 ` Manuel Schoelling -1 siblings, 0 replies; 10+ messages in thread From: Manuel Schoelling @ 2014-05-25 18:43 UTC (permalink / raw) To: Greg KH Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On So, 2014-05-25 at 11:33 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: > > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > > > To be future-proof and for better readability the time comparisons are > > > > modified to use time_before() instead of plain, error-prone math. > > > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > > --- > > > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > This patch doesn't apply, can you please refresh it against my latest > > > tree and resend? > > That's weird. I pulled the lastest master from Linus and rebased the > > patch, but no modification of my patch was required (latest commit > > before my patch to that file was > > 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). > > > > Maybe you have a more recent version than Linus? > > > I have a much different version from Linus, with a few thousand patches > added, otherwise how would I be able to queue up stuff to go to Linus > for the next kernel release? :) > > For the staging patches, either use the linux-next tree (which you > should use for all kernel development), or my staging.git tree, and the > staging-next branch on git.kernel.org, which is what gets pulled into > linux-next every week-day. > > If you have more questions about this, take a look at > Documentation/development-process/ it should explain how patches move > to Linus and why working against Linus's tree isn't going to get you > very far. Ok, thanks for your answer, Greg. I will use the linux-next tree and send you a new version of that patch today. Bye, Manuel > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: gdm72xx: use time_before() @ 2014-05-25 18:43 ` Manuel Schoelling 0 siblings, 0 replies; 10+ messages in thread From: Manuel Schoelling @ 2014-05-25 18:43 UTC (permalink / raw) To: Greg KH Cc: devel, arnd, peter.p.waskiewicz.jr, kernel-janitors, linux-kernel, khoroshilov On So, 2014-05-25 at 11:33 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: > > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > > > To be future-proof and for better readability the time comparisons are > > > > modified to use time_before() instead of plain, error-prone math. > > > > > > > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > > > > --- > > > > drivers/staging/gdm72xx/gdm_usb.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > This patch doesn't apply, can you please refresh it against my latest > > > tree and resend? > > That's weird. I pulled the lastest master from Linus and rebased the > > patch, but no modification of my patch was required (latest commit > > before my patch to that file was > > 8943a92fc257c439ffe55fb0f9896be57c58c56b according to my repo). > > > > Maybe you have a more recent version than Linus? > > > I have a much different version from Linus, with a few thousand patches > added, otherwise how would I be able to queue up stuff to go to Linus > for the next kernel release? :) > > For the staging patches, either use the linux-next tree (which you > should use for all kernel development), or my staging.git tree, and the > staging-next branch on git.kernel.org, which is what gets pulled into > linux-next every week-day. > > If you have more questions about this, take a look at > Documentation/development-process/ it should explain how patches move > to Linus and why working against Linus's tree isn't going to get you > very far. Ok, thanks for your answer, Greg. I will use the linux-next tree and send you a new version of that patch today. Bye, Manuel > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-05-25 18:43 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-25 13:08 [PATCH] gdm72xx: use time_before() Manuel Schölling 2014-05-25 13:08 ` Manuel Schölling 2014-05-25 18:14 ` [PATCH] staging: " Greg KH 2014-05-25 18:14 ` Greg KH 2014-05-25 18:24 ` Manuel Schoelling 2014-05-25 18:24 ` Manuel Schoelling 2014-05-25 18:33 ` Greg KH 2014-05-25 18:33 ` Greg KH 2014-05-25 18:43 ` Manuel Schoelling 2014-05-25 18:43 ` Manuel Schoelling
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.