From: Al Viro <viro@ZenIV.linux.org.uk>
To: Hugh Dickins <hughd@google.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/process_vm_access: move into ipc/
Date: Mon, 26 May 2014 20:53:41 +0100 [thread overview]
Message-ID: <20140526195341.GQ18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LSU.2.11.1405261210140.3411@eggly.anvils>
On Mon, May 26, 2014 at 12:16:20PM -0700, Hugh Dickins wrote:
> On Sat, 24 May 2014, Konstantin Khlebnikov wrote:
>
> > "CROSS_MEMORY_ATTACH" and mm/process_vm_access.c seems misnamed and misplaced.
> > Actually it's a kind of IPC and it has no more relation to MM than sys_read().
> > This patch moves code into ipc/ and config option into init/Kconfig.
> >
> > Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
>
> I disagree, and SysV's ipc/ isn't where I would expect to find it.
> How about we just leave it where it is in mm?
Anything playing with get_user_pages(tsk, ...) with tsk != current is very
much a part of VM guts.
While we are at it, do_generic_file_read() *is* in mm/filemap.c. And signals
and pipes are also "a kind of IPC", so the rationale is really weak.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Hugh Dickins <hughd@google.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/process_vm_access: move into ipc/
Date: Mon, 26 May 2014 20:53:41 +0100 [thread overview]
Message-ID: <20140526195341.GQ18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LSU.2.11.1405261210140.3411@eggly.anvils>
On Mon, May 26, 2014 at 12:16:20PM -0700, Hugh Dickins wrote:
> On Sat, 24 May 2014, Konstantin Khlebnikov wrote:
>
> > "CROSS_MEMORY_ATTACH" and mm/process_vm_access.c seems misnamed and misplaced.
> > Actually it's a kind of IPC and it has no more relation to MM than sys_read().
> > This patch moves code into ipc/ and config option into init/Kconfig.
> >
> > Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
>
> I disagree, and SysV's ipc/ isn't where I would expect to find it.
> How about we just leave it where it is in mm?
Anything playing with get_user_pages(tsk, ...) with tsk != current is very
much a part of VM guts.
While we are at it, do_generic_file_read() *is* in mm/filemap.c. And signals
and pipes are also "a kind of IPC", so the rationale is really weak.
next prev parent reply other threads:[~2014-05-26 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 13:59 [PATCH] mm/process_vm_access: move into ipc/ Konstantin Khlebnikov
2014-05-24 13:59 ` Konstantin Khlebnikov
2014-05-26 19:16 ` Hugh Dickins
2014-05-26 19:16 ` Hugh Dickins
2014-05-26 19:53 ` Al Viro [this message]
2014-05-26 19:53 ` Al Viro
2014-05-26 19:59 ` Konstantin Khlebnikov
2014-05-26 19:59 ` Konstantin Khlebnikov
2014-05-26 20:25 ` Hugh Dickins
2014-05-26 20:25 ` Hugh Dickins
2014-05-26 21:05 ` Davidlohr Bueso
2014-05-26 21:05 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526195341.GQ18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.