All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 00/20] xfsprogs: introduce the free inode btree
Date: Tue, 27 May 2014 08:40:33 +1000	[thread overview]
Message-ID: <20140526224033.GP18954@dastard> (raw)
In-Reply-To: <1399465319-65066-1-git-send-email-bfoster@redhat.com>

On Wed, May 07, 2014 at 08:21:39AM -0400, Brian Foster wrote:
> Hi all,
> 
> Here's v4 of the finobt series for xfsprogs. Patches 1-10 are unchanged
> as they are based on the corresponding kernel patches, which have now
> been merged.
> 
> v4 includes some fairly isolated fixes for mkfs and repair based on
> review feedback for v3:
> 
> 	http://oss.sgi.com/archives/xfs/2014-04/msg00239.html
> 
> Some concern was raised over xfs_repair performance based on the
> implementation of patch 17 in v3, so I have run a few repair tests on
> largish filesystems. Tests involved creating a large number of inodes on
> a 1TB 4xraid0, freeing a random percentage to populate the finobt and
> running xfs_repair (e.g., no actual corruptions). xfs_repair was run
> normally (with these patches) and with a change to skip the finobt
> processing via an xfs_sb_version_hasfinobt() hack. The tests were run on
> a 16xcpu, 32GB RAM server.

I still have some concerns about this simply based on the algorithm
and that it will come back an bite us eventually, but for the moment
I think you've done enough to show that it's not going to an
immediate issue.

I haven't seen anything else that needs fixing or causes problems,
so I'm going to merge it for 3.2.1.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-05-26 22:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 12:21 [PATCH v4 00/20] xfsprogs: introduce the free inode btree Brian Foster
2014-05-07 12:21 ` [PATCH v4 01/20] xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers Brian Foster
2014-05-07 12:21 ` [PATCH v4 02/20] xfs: reserve v5 superblock read-only compat. feature bit for finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 03/20] xfs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2014-05-07 12:21 ` [PATCH v4 04/20] xfs: update inode allocation/free transaction reservations for finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 05/20] xfs: insert newly allocated inode chunks into the finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 06/20] xfs: use and update the finobt on inode allocation Brian Foster
2014-05-07 12:21 ` [PATCH v4 07/20] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2014-05-07 12:21 ` [PATCH v4 08/20] xfs: update the finobt on inode free Brian Foster
2014-05-07 12:21 ` [PATCH v4 09/20] xfs: report finobt status in fs geometry Brian Foster
2014-05-07 12:21 ` [PATCH v4 10/20] xfs: enable the finobt feature on v5 superblocks Brian Foster
2014-05-07 12:21 ` [PATCH v4 11/20] xfsprogs/mkfs: finobt mkfs support Brian Foster
2014-05-07 12:21 ` [PATCH v4 12/20] xfsprogs/db: finobt support Brian Foster
2014-05-07 12:21 ` [PATCH v4 13/20] xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation Brian Foster
2014-05-07 12:21 ` [PATCH v4 14/20] xfsprogs/repair: phase 2 finobt scan Brian Foster
2014-05-07 12:21 ` [PATCH v4 15/20] xfsprogs/repair: pass btree block magic as param to build_ino_tree() Brian Foster
2014-05-07 12:21 ` [PATCH v4 16/20] xfsprogs/repair: pull the build_agi() call up out of the inode tree build Brian Foster
2014-05-07 12:21 ` [PATCH v4 17/20] xfsprogs/repair: helpers for finding in-core inode records w/ free inodes Brian Foster
2014-05-07 12:21 ` [PATCH v4 18/20] xfsprogs/repair: reconstruct the finobt in phase 5 Brian Foster
2014-05-07 12:21 ` [PATCH v4 19/20] xfsprogs/growfs: report finobt status in fs geometry (xfs_info) Brian Foster
2014-05-07 12:21 ` [PATCH v4 20/20] xfsprogs/db: add finobt support to metadump Brian Foster
2014-05-26 22:40 ` Dave Chinner [this message]
2014-05-27 12:06   ` [PATCH v4 00/20] xfsprogs: introduce the free inode btree Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140526224033.GP18954@dastard \
    --to=david@fromorbit.com \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.