From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 2/7] xfs: add support FALLOC_FL_COLLAPSE_RANGE for fallocate
Date: Wed, 28 May 2014 08:51:38 +1000 [thread overview]
Message-ID: <20140527225138.GD8554@dastard> (raw)
In-Reply-To: <53850F92.7010401@sgi.com>
On Tue, May 27, 2014 at 05:20:02PM -0500, Mark Tinguely wrote:
> On 09/02/13 09:29, Namjae Jeon wrote:
> >From: Namjae Jeon<namjae.jeon@samsung.com>
> >
> >Add support FALLOC_FL_COLLAPSE_RANGE for fallocate.
> >
> >Signed-off-by: Namjae Jeon<namjae.jeon@samsung.com>
> >Signed-off-by: Ashish Sangwan<a.sangwan@samsung.com>
> >---
>
> >+ /* Check if we can merge 2 adjacent extents */
> >+ if ((state & BMAP_LEFT_VALID) && !(state & BMAP_LEFT_DELAY) &&
> >+ left.br_startoff + left.br_blockcount == startoff &&
> >+ left.br_startblock + left.br_blockcount ==
> >+ xfs_bmbt_get_startblock(gotp) &&
> >+ xfs_bmbt_get_state(gotp) == left.br_state &&
> >+ left.br_blockcount + xfs_bmbt_get_blockcount(gotp) <=
> >+ MAXEXTLEN) {
> >+ blockcount =
> >+ left.br_blockcount + xfs_bmbt_get_blockcount(gotp);
> >+ state |= BMAP_LEFT_CONTIG;
> >+ xfs_iext_remove(ip, *current_ext, 1, 0);
> >+ XFS_IFORK_NEXT_SET(ip, whichfork,
> >+ XFS_IFORK_NEXTENTS(ip, whichfork) - 1);
> >+ gotp = xfs_iext_get_ext(ifp, --*current_ext);
> >+ }
> >+
> >+ if (cur) {
> >+ error = xfs_bmbt_lookup_eq(cur,
> >+ xfs_bmbt_get_startoff(gotp),
> >+ xfs_bmbt_get_startblock(gotp),
> >+ xfs_bmbt_get_blockcount(gotp),
> >+ &i);
> >+ if (error)
> >+ goto del_cursor;
> >+ XFS_WANT_CORRUPTED_GOTO(i == 1, del_cursor);
>
> I can reliably trigger this XFS_WANT_CORRUPTED_GOTO() with a
> fsstress that fills the filesystem:
>
> xfstests > ltp/fsstress -d /mnt/scratch -s 1370236858 -p 512 -n 8192 &
Hasn't reproduced after 10 minutes of running at ENOSPC here - how
long does it take to reproduce? What storage hardware are you
testing on? How many CPUs? RAM? ....
http://xfs.org/index.php/XFS_FAQ#Q:_What_information_should_I_include_when_reporting_a_problem.3F
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-27 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 14:29 [PATCH v2 2/7] xfs: add support FALLOC_FL_COLLAPSE_RANGE for fallocate Namjae Jeon
2013-09-02 14:29 ` Namjae Jeon
2014-05-27 22:20 ` Mark Tinguely
2014-05-27 22:51 ` Dave Chinner [this message]
2014-05-27 22:56 ` Mark Tinguely
2014-05-28 0:29 ` Dave Chinner
2014-05-28 22:48 ` Dave Chinner
2014-05-29 14:27 ` Mark Tinguely
2014-05-31 0:39 ` Dave Chinner
2014-06-01 1:22 ` Mark Tinguely
2014-06-01 1:25 ` Mark Tinguely
2014-06-01 22:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527225138.GD8554@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.