Re: [PATCH v6 1/2] clk: shmobile: r8a7779: Add clocks support

[Simon Horman <horms@verge.net.au>]

On Wed, May 28, 2014 at 10:42:05AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, May 28, 2014 at 3:08 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > +#include <dt-bindings/clock/r8a7779-clock.h>
> >>
> >> This currently causes a build error in Linux-next, since the header file
> >> has not been merged along with the driver.
> >
> > Hi Arnd,
> >
> > I'm a little unsure what combination of Kernel config options you
> > are using to compile this driver in linux-next but I do agree
> > that the header is missing and that would cause the compile to fail.
> > I apologise for that oversight.
> >
> > I believe that a good fix is to add the header, which I already have queued-up
> > in the renesas tree for v3.17. I wonder if Mike would consider taking
> > the following patch for v3.16. Alternatively I would be happy to send
> > it it to arm-soc as a fix for v3.16.
> 
> IIUIC, the only reason the driver source needs the header file is:
> 
> #define CPG_NUM_CLOCKS                  (R8A7779_CLK_OUT + 1)
> 
> Why not
> 
> #define CPG_NUM_CLOCKS                  8
> 
> and drop the include?
> 
> Or better, use "num_clks" (from of_property_count_strings(np,
> "clock-output-names")), like the other R-Car drivers do.

The latter I like. But I don't see any harm in fixing
the immediate problem using a patch that has already been reviewed.