All of lore.kernel.org
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/9] arm64: KVM: debug infrastructure support
Date: Wed, 28 May 2014 11:58:33 +0200	[thread overview]
Message-ID: <20140528095833.GO16428@lvm> (raw)
In-Reply-To: <5385B2DD.8090200@arm.com>

On Wed, May 28, 2014 at 10:56:45AM +0100, Marc Zyngier wrote:
> On 25/05/14 16:34, Christoffer Dall wrote:
> > On Tue, May 20, 2014 at 05:55:36PM +0100, Marc Zyngier wrote:
> >> This patch series adds debug support, a key feature missing from the
> >> KVM/arm64 port.
> >>
> >> The main idea is to keep track of whether the debug registers are
> >> "dirty" (changed by the guest) or not. In this case, perform the usual
> >> save/restore dance, for one run only. It means we only have a penalty
> >> if a guest is actively using the debug registers.
> >>
> >> The amount of registers is properly frightening, but CPUs actually
> >> only implement a subset of them. Also, there is a number of registers
> >> we don't bother emulating (things having to do with external debug and
> >> OSlock).
> > 
> > What is the rationale about not having to deal with external debug and
> > OSlock?
> 
> External debug is when you actually plug a physical JTAG into the CPU.
> OSlock is a way to prevent "other software" to play with the debug
> registers. My understanding is that it is only useful in combination
> with the external debug.
> 
> In both case, implementing support for this is probably not worth the
> effort, at least for the time being.
> 
OK, can we document that somewhere clearly in the code then so we know
how we can simply ignore those registers?

Thanks,
-Christoffer

WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Will Deacon <Will.Deacon@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Anup Patel <anup.patel@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 0/9] arm64: KVM: debug infrastructure support
Date: Wed, 28 May 2014 11:58:33 +0200	[thread overview]
Message-ID: <20140528095833.GO16428@lvm> (raw)
In-Reply-To: <5385B2DD.8090200@arm.com>

On Wed, May 28, 2014 at 10:56:45AM +0100, Marc Zyngier wrote:
> On 25/05/14 16:34, Christoffer Dall wrote:
> > On Tue, May 20, 2014 at 05:55:36PM +0100, Marc Zyngier wrote:
> >> This patch series adds debug support, a key feature missing from the
> >> KVM/arm64 port.
> >>
> >> The main idea is to keep track of whether the debug registers are
> >> "dirty" (changed by the guest) or not. In this case, perform the usual
> >> save/restore dance, for one run only. It means we only have a penalty
> >> if a guest is actively using the debug registers.
> >>
> >> The amount of registers is properly frightening, but CPUs actually
> >> only implement a subset of them. Also, there is a number of registers
> >> we don't bother emulating (things having to do with external debug and
> >> OSlock).
> > 
> > What is the rationale about not having to deal with external debug and
> > OSlock?
> 
> External debug is when you actually plug a physical JTAG into the CPU.
> OSlock is a way to prevent "other software" to play with the debug
> registers. My understanding is that it is only useful in combination
> with the external debug.
> 
> In both case, implementing support for this is probably not worth the
> effort, at least for the time being.
> 
OK, can we document that somewhere clearly in the code then so we know
how we can simply ignore those registers?

Thanks,
-Christoffer

  reply	other threads:[~2014-05-28  9:58 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 16:55 [PATCH v2 0/9] arm64: KVM: debug infrastructure support Marc Zyngier
2014-05-20 16:55 ` Marc Zyngier
2014-05-20 16:55 ` [PATCH v2 1/9] arm64: KVM: rename pm_fake handler to trap_raz_wi Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:34   ` Christoffer Dall
2014-05-25 15:34     ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 2/9] arm64: move DBG_MDSCR_* to asm/debug-monitors.h Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:34   ` Christoffer Dall
2014-05-25 15:34     ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 3/9] arm64: KVM: add trap handlers for AArch64 debug registers Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:34   ` Christoffer Dall
2014-05-25 15:34     ` Christoffer Dall
2014-05-28 10:27     ` Marc Zyngier
2014-05-28 10:27       ` Marc Zyngier
2014-05-20 16:55 ` [PATCH v2 4/9] arm64: KVM: common infrastructure for handling AArch32 CP14/CP15 Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:34   ` Christoffer Dall
2014-05-25 15:34     ` Christoffer Dall
2014-05-28 10:34     ` Marc Zyngier
2014-05-28 10:34       ` Marc Zyngier
2014-05-20 16:55 ` [PATCH v2 5/9] arm64: KVM: use separate tables for AArch32 32 and 64bit traps Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:35   ` Christoffer Dall
2014-05-25 15:35     ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 6/9] arm64: KVM: check ordering of all system register tables Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:35   ` Christoffer Dall
2014-05-25 15:35     ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 7/9] arm64: KVM: add trap handlers for AArch32 debug registers Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:35   ` Christoffer Dall
2014-05-25 15:35     ` Christoffer Dall
2014-05-28 16:00     ` Marc Zyngier
2014-05-28 16:00       ` Marc Zyngier
2014-05-29  8:53       ` Christoffer Dall
2014-05-29  8:53         ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 8/9] arm64: KVM: implement lazy world switch for " Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:35   ` Christoffer Dall
2014-05-25 15:35     ` Christoffer Dall
2014-05-20 16:55 ` [PATCH v2 9/9] arm64: KVM: enable trapping of all " Marc Zyngier
2014-05-20 16:55   ` Marc Zyngier
2014-05-25 15:36   ` Christoffer Dall
2014-05-25 15:36     ` Christoffer Dall
2014-05-28 16:10     ` Marc Zyngier
2014-05-28 16:10       ` Marc Zyngier
2014-05-29  8:55       ` Christoffer Dall
2014-05-29  8:55         ` Christoffer Dall
2014-05-25 15:34 ` [PATCH v2 0/9] arm64: KVM: debug infrastructure support Christoffer Dall
2014-05-25 15:34   ` Christoffer Dall
2014-05-28  9:56   ` Marc Zyngier
2014-05-28  9:56     ` Marc Zyngier
2014-05-28  9:58     ` Christoffer Dall [this message]
2014-05-28  9:58       ` Christoffer Dall
2014-05-28 10:11       ` Marc Zyngier
2014-05-28 10:11         ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140528095833.GO16428@lvm \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.