From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH
Date: Thu, 29 May 2014 12:17:39 -0700 [thread overview]
Message-ID: <20140529191738.GA18567@atomide.com> (raw)
In-Reply-To: <20140529190227.GB18230@amd.pavel.ucw.cz>
* Pavel Machek <pavel@ucw.cz> [140529 12:03]:
> On Fri 2014-05-16 14:12:31, Tony Lindgren wrote:
> > * Paul Bolle <pebolle@tiscali.nl> [140515 12:42]:
> > > A check for CONFIG_SX1_OLD_FLASH was added in v2.6.24. But the related
> > > Kconfig symbol was never part of the tree. So we can remove some dead
> > > code.
> >
> > Thanks applying into omap-for-v3.16/board.
>
> Actually... It seems there are two variant of SX1, and this is very
> useful piece of documentation how the _other_ variant looks.
>
> And if someone is hacking linux on sx1, he can probably figure out
> #ifdef in .c file...
>
> IOW adding the config option might be better solution.
Or just a comment saying the same?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH
Date: Thu, 29 May 2014 12:17:39 -0700 [thread overview]
Message-ID: <20140529191738.GA18567@atomide.com> (raw)
In-Reply-To: <20140529190227.GB18230@amd.pavel.ucw.cz>
* Pavel Machek <pavel@ucw.cz> [140529 12:03]:
> On Fri 2014-05-16 14:12:31, Tony Lindgren wrote:
> > * Paul Bolle <pebolle@tiscali.nl> [140515 12:42]:
> > > A check for CONFIG_SX1_OLD_FLASH was added in v2.6.24. But the related
> > > Kconfig symbol was never part of the tree. So we can remove some dead
> > > code.
> >
> > Thanks applying into omap-for-v3.16/board.
>
> Actually... It seems there are two variant of SX1, and this is very
> useful piece of documentation how the _other_ variant looks.
>
> And if someone is hacking linux on sx1, he can probably figure out
> #ifdef in .c file...
>
> IOW adding the config option might be better solution.
Or just a comment saying the same?
Regards,
Tony
next prev parent reply other threads:[~2014-05-29 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 19:41 [PATCH] ARM: OMAP: SX1: remove check for CONFIG_SX1_OLD_FLASH Paul Bolle
2014-05-15 19:41 ` Paul Bolle
2014-05-16 21:12 ` Tony Lindgren
2014-05-16 21:12 ` Tony Lindgren
2014-05-29 19:02 ` Pavel Machek
2014-05-29 19:02 ` Pavel Machek
2014-05-29 19:17 ` Tony Lindgren [this message]
2014-05-29 19:17 ` Tony Lindgren
2014-05-29 19:42 ` Pavel Machek
2014-05-29 19:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529191738.GA18567@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.