All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Fixed coding style problem
Date: Thu, 29 May 2014 21:57:39 +0000	[thread overview]
Message-ID: <20140529220107.GA22685@kroah.com> (raw)
In-Reply-To: <1401400436-4396-1-git-send-email-cmroliv@gmail.com>

Your subject: should say where you did this.  For this example, it would
be:
	Subject: staging: wlan-ng: fixed...

Also, "what" coding style problem did you fix?


On Thu, May 29, 2014 at 10:53:56PM +0100, Miguel Oliveira wrote:
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>

You sould say what you did, before the signed-off-by line.

Can you fix that up and resend please?

Also use scripts/get_maintainers.pl to send to the proper people and
mailing list.

thanks,

greg k-h

  reply	other threads:[~2014-05-29 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 21:53 [PATCH] Fixed coding style problem Miguel Oliveira
2014-05-29 21:57 ` Greg KH [this message]
2014-05-29 22:03 ` Dan Carpenter
2014-05-29 22:07 ` Miguel Oliveira
  -- strict thread matches above, loose matches on Subject: below --
2014-06-20 14:50 rbasukala
2014-06-20 15:20 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140529220107.GA22685@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.