[PATCH] Fixed coding style problem

[PATCH] Fixed coding style problem

[Miguel Oliveira]

Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
---
 drivers/staging/wlan-ng/p80211req.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
index cdfd808..3b3fccc 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -109,7 +109,7 @@ int p80211req_dorequest(wlandevice_t *wlandev, u8 *msgbuf)
 	/* Check Permissions */
 	if (!capable(CAP_NET_ADMIN) &&
 	(msg->msgcode != DIDmsg_dot11req_mibget)) {
-		printk(KERN_ERR
+		netdev_err(netdev,
 		       "%s: only dot11req_mibget allowed for non-root.\n",
 		       wlandev->name);
 		return -EPERM;
--
1.7.10.4

Re: [PATCH] Fixed coding style problem

[Greg KH]

Your subject: should say where you did this.  For this example, it would
be:
	Subject: staging: wlan-ng: fixed...

Also, "what" coding style problem did you fix?


On Thu, May 29, 2014 at 10:53:56PM +0100, Miguel Oliveira wrote:
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>

You sould say what you did, before the signed-off-by line.

Can you fix that up and resend please?

Also use scripts/get_maintainers.pl to send to the proper people and
mailing list.

thanks,

greg k-h

Re: [PATCH] Fixed coding style problem

[Dan Carpenter]

Work against linux-next.  Someone already fixed this.  The subject
should have been:

[PATCH] staging: wlan-ng: <something something netdev_err()>

With correct prefix and a more descriptive title.  See how Vitaly did
it: http://www.spinics.net/lists/linux-driver-devel/msg46770.html

regards,
dan carpenter

Re: [PATCH] Fixed coding style problem

[Miguel Oliveira]

Thanks Dan and Greg for the hints, and sorry for this, its was my 1st
attenpt to patch something.

2014-05-29 23:03 GMT+01:00 Dan Carpenter <dan.carpenter@oracle.com>:
> Work against linux-next.  Someone already fixed this.  The subject
> should have been:
>
> [PATCH] staging: wlan-ng: <something something netdev_err()>
>
> With correct prefix and a more descriptive title.  See how Vitaly did
> it: http://www.spinics.net/lists/linux-driver-devel/msg46770.html
>
> regards,
> dan carpenter
>

[PATCH] Fixed coding style problem

[rbasukala]

---
 drivers/staging/netlogic/xlr_net.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index e320d6b..3ad48a0 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -1105,6 +1105,7 @@ err_gmac:
 static int xlr_net_remove(struct platform_device *pdev)
 {
 	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
 	unregister_netdev(priv->ndev);
 	mdiobus_unregister(priv->mii_bus);
 	mdiobus_free(priv->mii_bus);
-- 
1.7.1

Re: [PATCH] Fixed coding style problem

[Greg KH]

On Fri, Jun 20, 2014 at 10:50:09AM -0400, rbasukala wrote:
> ---
>  drivers/staging/netlogic/xlr_net.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index e320d6b..3ad48a0 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -1105,6 +1105,7 @@ err_gmac:
>  static int xlr_net_remove(struct platform_device *pdev)
>  {
>  	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +
>  	unregister_netdev(priv->ndev);
>  	mdiobus_unregister(priv->mii_bus);
>  	mdiobus_free(priv->mii_bus);


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot