Fix for libxml++_ptest.patch with out-of-source build

Fix for libxml++_ptest.patch with out-of-source build

[Lewis, Nick]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

The libxml++_ptest.patch currently supplied with the libxml++ recipe does not produce a Makefile that works for out-of-source builds. Please find attached a patch that resolves this problem

Apologies
Nick

Nick Lewis
nick.lewis@usa.g4s.com<mailto:nick.lewis@usa.g4s.com>
+44 1684 277137<tel:+441684277137>
www.g4stechnology.com<http://www.g4stechnology.com/>
New Challenge House, International Drive, Tewkesbury, Gloucestershire, GL20 8UQ, UK

P Please consider the environment before printing this email


________________________________
The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.

[-- Attachment #2: 0001-Fix-libxml-_ptest.patch-with-out-of-source-build.patch --]
[-- Type: application/octet-stream, Size: 1247 bytes --]

From 66b57260164e6cf486bd7f7f26c41112e603dfd8 Mon Sep 17 00:00:00 2001
From: Nick Lewis <nick.lewis@usa.g4s.com>
Date: Tue, 6 May 2014 13:38:04 +0100
Subject: [PATCH] Fix libxml++_ptest.patch with out-of-source build

---
 meta-oe/recipes-core/libxml/libxml++-2.37.1/libxml++_ptest.patch | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-core/libxml/libxml++-2.37.1/libxml++_ptest.patch b/meta-oe/recipes-core/libxml/libxml++-2.37.1/libxml++_ptest.patch
index a18822f..1e847be 100644
--- a/meta-oe/recipes-core/libxml/libxml++-2.37.1/libxml++_ptest.patch
+++ b/meta-oe/recipes-core/libxml/libxml++-2.37.1/libxml++_ptest.patch
@@ -65,9 +65,9 @@ index d9541ca..c28b49c 100644
 +	$(MKDIR_P) $(DESTDIR)/examples
 +	cp --parents $(check_DOTLIBS) $(DESTDIR)/examples
 +	cp --parents $(check_SCRIPTS) $(DESTDIR)/examples
-+	cp --parents $(dist_noinst_DATA) $(DESTDIR)/examples
++	$(foreach i, $(dist_noinst_DATA), cp --parents $(srcdir)/$(i) $(DESTDIR)/examples;)
 +	cp Makefile $(DESTDIR)/examples
 +	$(MKDIR_P) $(DESTDIR)/macros
-+	cp ../macros/test-driver $(DESTDIR)/macros
++	cp $(srcdir)/../macros/test-driver $(DESTDIR)/macros
 +	sed -i -e 's|^Makefile:|_Makefile:|' $(DESTDIR)/examples/Makefile
 +
-- 
1.9.1

Re: Fix for libxml++_ptest.patch with out-of-source build

[Khem Raj]

Nick

On Tue, May 6, 2014 at 6:07 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
> The libxml++_ptest.patch currently supplied with the libxml++ recipe does not produce a Makefile that works for out-of-source builds. Please find attached a patch that resolves this problem
>

thanks for the note. However I would encourage you to submit a patch
for meta-oe if you can guidelines are here

http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

Thanks
-Khem

Re: Fix for libxml++_ptest.patch with out-of-source build

[Lewis, Nick]

>thanks for the note. However I would encourage you to submit a patch for meta-oe if you can guidelines are here
>
>http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
>
>Thanks

Khem

I cannot use git send-email as only MAPI email is supported here . However I have redone the patch using git format-patch -s and pasted it into an email under the title "libxml plus plus ptest with B noteq S". I hope this can be applied in a similar way

Please let me know if there are any problems with it

Nick



The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.

Re: Fix for libxml++_ptest.patch with out-of-source build

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]

On Wed, May 07, 2014 at 01:07:22PM +0100, Lewis, Nick wrote:
> >thanks for the note. However I would encourage you to submit a patch for meta-oe if you can guidelines are here
> >
> >http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
> >
> >Thanks
> 
> Khem
> 
> I cannot use git send-email as only MAPI email is supported here . However I have redone the patch using git format-patch -s and pasted it into an email under the title "libxml plus plus ptest with B noteq S". I hope this can be applied in a similar way
> 
> Please let me know if there are any problems with it

It still does not apply

see http://patchwork.openembedded.org/patch/72639/

> 
> Nick
> 
> 
> 
> The details of this company are as follows:
> G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.
> 
> This communication may contain information which is confidential, personal and/or privileged.
> 
> It is for the exclusive use of the intended recipient(s).
> If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.
> 
> Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.
> 
> Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.
> 
> This e-mail has been scanned for all viruses by MessageLabs.
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Fix for libxml++_ptest.patch with out-of-source build

[Lewis, Nick]

>It still does not apply
>
>see http://patchwork.openembedded.org/patch/72639/

Martin

Given the problems submitting a patch from my mail client would it be possible please to make a manual edit

s|cp --parents $(dist_noinst_DATA) $(DESTDIR)/examples|cd $(srcdir) && cp --parents $(dist_noinst_DATA) $(DESTDIR)/examples

(not as in patch 72639) and

s|cp ../macros/test-driver $(DESTDIR)/macros|cp $(srcdir)/../macros/test-driver $(DESTDIR)/macros

(as per patch 72639)
--
Nick

The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.