Re: [PATCH RESEND] sgi-gru: use time_before()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Dimitri Sivanich <sivanich@sgi.com>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH RESEND] sgi-gru: use time_before()
Date: Fri, 30 May 2014 17:15:07 +0000	[thread overview]
Message-ID: <20140530171507.GA85969@sgi.com> (raw)
In-Reply-To: <1401457259-17401-1-git-send-email-manuel.schoelling@gmx.de>

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Fri, May 30, 2014 at 03:40:59PM +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_before() instead of plain, error-prone math.
> 
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> ---
>  drivers/misc/sgi-gru/grumain.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..1525870 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -930,6 +930,7 @@ int gru_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
>  {
>  	struct gru_thread_state *gts;
>  	unsigned long paddr, vaddr;
> +	unsigned long expires;
>  
>  	vaddr = (unsigned long)vmf->virtual_address;
>  	gru_dbg(grudev, "vma %p, vaddr 0x%lx (0x%lx)\n",
> @@ -954,7 +955,8 @@ again:
>  			mutex_unlock(&gts->ts_ctxlock);
>  			set_current_state(TASK_INTERRUPTIBLE);
>  			schedule_timeout(GRU_ASSIGN_DELAY);  /* true hack ZZZ */
> -			if (gts->ts_steal_jiffies + GRU_STEAL_DELAY < jiffies)
> +			expires = gts->ts_steal_jiffies + GRU_STEAL_DELAY;
> +			if (time_before(expires, jiffies))
>  				gru_steal_context(gts);
>  			goto again;
>  		}
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: Dimitri Sivanich <sivanich@sgi.com>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH RESEND] sgi-gru: use time_before()
Date: Fri, 30 May 2014 12:15:07 -0500	[thread overview]
Message-ID: <20140530171507.GA85969@sgi.com> (raw)
In-Reply-To: <1401457259-17401-1-git-send-email-manuel.schoelling@gmx.de>

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Fri, May 30, 2014 at 03:40:59PM +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_before() instead of plain, error-prone math.
> 
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> ---
>  drivers/misc/sgi-gru/grumain.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..1525870 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -930,6 +930,7 @@ int gru_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
>  {
>  	struct gru_thread_state *gts;
>  	unsigned long paddr, vaddr;
> +	unsigned long expires;
>  
>  	vaddr = (unsigned long)vmf->virtual_address;
>  	gru_dbg(grudev, "vma %p, vaddr 0x%lx (0x%lx)\n",
> @@ -954,7 +955,8 @@ again:
>  			mutex_unlock(&gts->ts_ctxlock);
>  			set_current_state(TASK_INTERRUPTIBLE);
>  			schedule_timeout(GRU_ASSIGN_DELAY);  /* true hack ZZZ */
> -			if (gts->ts_steal_jiffies + GRU_STEAL_DELAY < jiffies)
> +			expires = gts->ts_steal_jiffies + GRU_STEAL_DELAY;
> +			if (time_before(expires, jiffies))
>  				gru_steal_context(gts);
>  			goto again;
>  		}
> -- 
> 1.7.10.4

next prev parent reply	other threads:[~2014-05-30 17:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 13:40 [PATCH RESEND] sgi-gru: use time_before() Manuel Schölling
2014-05-30 13:40 ` Manuel Schölling
2014-05-30 17:15 ` Dimitri Sivanich [this message]
2014-05-30 17:15   ` Dimitri Sivanich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530171507.GA85969@sgi.com \
    --to=sivanich@sgi.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.schoelling@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.