All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, grant.likely@linaro.org,
	linus.walleij@linaro.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices
Date: Fri, 30 May 2014 20:25:16 +0100	[thread overview]
Message-ID: <20140530192516.GA4319@lee--X1> (raw)
In-Reply-To: <20140530174800.GA4917@katana>

> > Would you mind telling me what I have changed that affects drivers
> > registering via Sysfs?
> 
> Check Documentation/i2c/instantiating-devices, method 4. If a driver
> does not have i2c_device_id, then this method won't work because the
> newly created device has no of_node or ACPI_node and nothing will match.
> Looking at the bigger picture, I'd really like to keep this feature.
> People use it.

Right, I read the function which provides the functionality, but my
point is; I don't think my patch changes the semantics in a way which
would adversely affect this option.  If you think that it does, can you
specify how please?

Does the sysfs method create a i2c_device_id table?  If not, how does
it probe successfully pre-patch?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices
Date: Fri, 30 May 2014 20:25:16 +0100	[thread overview]
Message-ID: <20140530192516.GA4319@lee--X1> (raw)
In-Reply-To: <20140530174800.GA4917@katana>

> > Would you mind telling me what I have changed that affects drivers
> > registering via Sysfs?
> 
> Check Documentation/i2c/instantiating-devices, method 4. If a driver
> does not have i2c_device_id, then this method won't work because the
> newly created device has no of_node or ACPI_node and nothing will match.
> Looking at the bigger picture, I'd really like to keep this feature.
> People use it.

Right, I read the function which provides the functionality, but my
point is; I don't think my patch changes the semantics in a way which
would adversely affect this option.  If you think that it does, can you
specify how please?

Does the sysfs method create a i2c_device_id table?  If not, how does
it probe successfully pre-patch?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-05-30 19:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 12:26 [PATCH 0/{1,1}] i2c: Make I2C ID tables non-mandatory for DT/ACPI Lee Jones
2014-05-30 12:26 ` Lee Jones
2014-05-30 12:26 ` Lee Jones
2014-05-30 12:26 ` [PATCH] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices Lee Jones
2014-05-30 12:26   ` Lee Jones
2014-05-30 12:36   ` Wolfram Sang
2014-05-30 12:36     ` Wolfram Sang
2014-05-30 12:55     ` Lee Jones
2014-05-30 12:55       ` Lee Jones
2014-05-30 12:55       ` Lee Jones
2014-05-30 13:34     ` Lee Jones
2014-05-30 13:34       ` Lee Jones
2014-05-30 13:34       ` Lee Jones
2014-05-30 17:48       ` Wolfram Sang
2014-05-30 17:48         ` Wolfram Sang
2014-05-30 17:48         ` Wolfram Sang
2014-05-30 19:25         ` Lee Jones [this message]
2014-05-30 19:25           ` Lee Jones
2014-05-31 13:48           ` Wolfram Sang
2014-05-31 13:48             ` Wolfram Sang
2014-05-31 13:48             ` Wolfram Sang
2014-06-02 12:16             ` Linus Walleij
2014-06-02 12:16               ` Linus Walleij
     [not found]               ` <CACRpkdZvyfA0aaJe3YuevXfA2pTZLRPZ3mQpitL6qD7=qE0Xyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-02 12:38                 ` Wolfram Sang
2014-06-02 12:38                   ` Wolfram Sang
2014-06-02 12:38                   ` Wolfram Sang
2014-06-02 13:26                   ` Linus Walleij
2014-06-02 13:26                     ` Linus Walleij
2014-06-02 13:26                   ` Lee Jones
2014-06-02 13:26                     ` Lee Jones
2014-06-02 14:29                 ` Michael Lawnick
2014-06-02 14:29                   ` Michael Lawnick
2014-06-02 14:29                   ` Michael Lawnick
2014-06-03 11:18                   ` Linus Walleij
2014-06-03 11:18                     ` Linus Walleij
2014-06-04  6:09                     ` Michael Lawnick
2014-06-04  6:09                       ` Michael Lawnick
     [not found]                       ` <538EB81B.3090807-Mmb7MZpHnFY@public.gmane.org>
2014-06-12  7:55                         ` Linus Walleij
2014-06-12  7:55                           ` Linus Walleij
2014-06-12  7:55                           ` Linus Walleij
     [not found]                           ` <CACRpkda3bL=y3Dmkf59LT97Liep=XEzgE3P-YngLeD_w1qcAzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-12  9:28                             ` Michael Lawnick
2014-06-12  9:28                               ` Michael Lawnick
2014-06-12  9:28                               ` Michael Lawnick
2014-05-30 12:26 ` Lee Jones
2014-05-30 12:26   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530192516.GA4319@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=grant.likely@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.