From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
Samuel Ortiz <samuel@sortiz.org>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/11] via-ircc: Remove useless return variables
Date: Sun, 01 Jun 2014 13:34:21 +0000 [thread overview]
Message-ID: <20140601133421.GQ15585@mwanda> (raw)
In-Reply-To: <538B11A6.30306@bfs.de>
On Sun, Jun 01, 2014 at 01:42:30PM +0200, walter harms wrote:
> >> static int via_ircc_read_dongle_id(int iobase)
> >> -{
> >> - int dongle_id = 9; /* Default to IBM */
> >> -
> >> +{/* Default to IBM */
> >
> > Yuck. And anyway, the comment should be on return line. (And of course
> > there should have been a #define IBM_DONGLE_ID 9, but that's probably
> > something for another patch.
> >
> >> IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n");
> >> - return dongle_id;
> >> + return 9;
>
>
> more over code and error msg do not fit,
> it returns a default of 9 (what ever that means) it does not look like
> an error. Sow the warning should be
>
> via-ircc: dongle probing not supported, please specify dongle_id module parameter. settting dongle_id=9
>
The print is ok. It's called like this:
328 /* Check if user has supplied the dongle id or not */
329 if (!dongle_id)
330 dongle_id = via_ircc_read_dongle_id(self->io.fir_base);
331 self->io.dongle_id = dongle_id;
If you don't use a module id then it acts like an IBM dongle by default.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
Samuel Ortiz <samuel@sortiz.org>,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/11] via-ircc: Remove useless return variables
Date: Sun, 1 Jun 2014 16:34:21 +0300 [thread overview]
Message-ID: <20140601133421.GQ15585@mwanda> (raw)
In-Reply-To: <538B11A6.30306@bfs.de>
On Sun, Jun 01, 2014 at 01:42:30PM +0200, walter harms wrote:
> >> static int via_ircc_read_dongle_id(int iobase)
> >> -{
> >> - int dongle_id = 9; /* Default to IBM */
> >> -
> >> +{/* Default to IBM */
> >
> > Yuck. And anyway, the comment should be on return line. (And of course
> > there should have been a #define IBM_DONGLE_ID 9, but that's probably
> > something for another patch.
> >
> >> IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n");
> >> - return dongle_id;
> >> + return 9;
>
>
> more over code and error msg do not fit,
> it returns a default of 9 (what ever that means) it does not look like
> an error. Sow the warning should be
>
> via-ircc: dongle probing not supported, please specify dongle_id module parameter. settting dongle_id=9
>
The print is ok. It's called like this:
328 /* Check if user has supplied the dongle id or not */
329 if (!dongle_id)
330 dongle_id = via_ircc_read_dongle_id(self->io.fir_base);
331 self->io.dongle_id = dongle_id;
If you don't use a module id then it acts like an IBM dongle by default.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-01 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 13:14 [PATCH 4/11] via-ircc: Remove useless return variables Peter Senna Tschudin
2014-05-31 13:14 ` Peter Senna Tschudin
2014-05-31 20:36 ` Dan Carpenter
2014-05-31 20:36 ` Dan Carpenter
2014-06-01 11:42 ` walter harms
2014-06-01 11:42 ` walter harms
2014-06-01 13:34 ` Dan Carpenter [this message]
2014-06-01 13:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601133421.GQ15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=samuel@sortiz.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.