From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] libata: consolidate ata_dev_classify()
Date: Mon, 2 Jun 2014 02:16:25 -0700 [thread overview]
Message-ID: <20140602091625.GA32301@infradead.org> (raw)
In-Reply-To: <1401692478-23557-2-git-send-email-hare@suse.de>
On Mon, Jun 02, 2014 at 09:01:16AM +0200, Hannes Reinecke wrote:
> ata_dev_classify() just uses the 'lbah' and 'lbam'
> fields from the taskfile, so we can as well use those
> as arguments and rip out the custom code from sas_ata.
There is no reason why SAS couldn't set up a taskfile structure either,
but this looks cleaner to me anyway, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But you really need to run libata changes past the linux-ide list
and not just the scsi list.
next prev parent reply other threads:[~2014-06-02 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 7:01 [PATCH 0/3] Initial SMR drive support Hannes Reinecke
2014-06-02 7:01 ` [PATCH 1/3] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-06-02 9:16 ` Christoph Hellwig [this message]
2014-06-02 7:01 ` [PATCH 2/3] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-06-02 9:17 ` Christoph Hellwig
2014-06-14 6:37 ` Hannes Reinecke
2014-06-02 7:01 ` [PATCH 3/3] scsi: Implement 'ZBC' device type Hannes Reinecke
2014-06-02 8:39 ` Christoph Hellwig
2014-06-02 8:46 ` Hannes Reinecke
2014-06-02 9:20 ` Christoph Hellwig
2014-06-02 9:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602091625.GA32301@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.