From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: James Bottomley <jbottomley@parallels.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] libata: Implement ATA_DEV_ZAC
Date: Sat, 14 Jun 2014 08:37:47 +0200 [thread overview]
Message-ID: <539BEDBB.6020206@suse.de> (raw)
In-Reply-To: <20140602091745.GB32301@infradead.org>
On 06/02/2014 11:17 AM, Christoph Hellwig wrote:
> This also need to be run past the libata maintainers and the linux-ide
> list..
>
>> + if ((lbam == 0xcd) && (lbah == 0xab)) {
>
> The inner braces here aren't needed.
>
True, but that's the coding style within that function.
There are several conditions with every of them following the same style.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-14 6:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 7:01 [PATCH 0/3] Initial SMR drive support Hannes Reinecke
2014-06-02 7:01 ` [PATCH 1/3] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-06-02 9:16 ` Christoph Hellwig
2014-06-02 7:01 ` [PATCH 2/3] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-06-02 9:17 ` Christoph Hellwig
2014-06-14 6:37 ` Hannes Reinecke [this message]
2014-06-02 7:01 ` [PATCH 3/3] scsi: Implement 'ZBC' device type Hannes Reinecke
2014-06-02 8:39 ` Christoph Hellwig
2014-06-02 8:46 ` Hannes Reinecke
2014-06-02 9:20 ` Christoph Hellwig
2014-06-02 9:19 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-11-05 12:08 [PATCHv2 0/3] Initial ZAC support Hannes Reinecke
2014-11-05 12:08 ` [PATCH 2/3] libata: Implement ATA_DEV_ZAC Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539BEDBB.6020206@suse.de \
--to=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.