From: Hani Benhabiles <kroosec@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients.
Date: Mon, 2 Jun 2014 23:09:02 +0100 [thread overview]
Message-ID: <20140602220902.GB5283@Inspiron-3521> (raw)
In-Reply-To: <20140602123206.GF3049@stefanha-thinkpad.redhat.com>
On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote:
> On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote:
> > Signed-off-by: Hani Benhabiles <hani@linux.com>
> > ---
> > include/block/nbd.h | 6 ++++++
> > nbd.c | 12 +++++++-----
> > 2 files changed, 13 insertions(+), 5 deletions(-)
>
> No explanation or link to specification for this new flag field? What's
> different about a new-style client?
With this flag is set, the server tells the client that it can send another
option if the server got a request with an option it doesn't understand (instead
of the server closing the connection.) Thus, the while(1) loop in 2/3.
The kernel in Documentation/blockdev/nbd.txt points to the NBD project for
documentation. The proto documentation is in [1]. Shouldn't Qemu also do the
same ?
[1] https://github.com/yoe/nbd/blob/master/doc/proto.txt
next prev parent reply other threads:[~2014-06-02 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401572382-11667-1-git-send-email-kroosec@gmail.com>
[not found] ` <1401572382-11667-2-git-send-email-kroosec@gmail.com>
2014-06-02 12:32 ` [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients Stefan Hajnoczi
2014-06-02 22:09 ` Hani Benhabiles [this message]
2014-06-04 8:01 ` Stefan Hajnoczi
[not found] ` <1401572382-11667-4-git-send-email-kroosec@gmail.com>
2014-06-03 11:33 ` [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing Paolo Bonzini
2014-06-04 22:33 ` Hani Benhabiles
2014-06-05 1:55 ` Paolo Bonzini
2014-06-05 9:58 ` Hani Benhabiles
2014-06-05 10:31 ` Paolo Bonzini
[not found] ` <1401572382-11667-3-git-send-email-kroosec@gmail.com>
2014-06-03 11:36 ` [Qemu-devel] [PATCH 2/3] nbd: Add exports listing support Paolo Bonzini
2014-06-04 22:35 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602220902.GB5283@Inspiron-3521 \
--to=kroosec@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.