[PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Paul E. McKenney]

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

A ksummit-discuss email thread looked at the difficulty recruiting
and retaining reviewers.  Paul Walmsley also noted the need for patch
submitters to know who the key reviewers are and suggested adding an
"R:" tag to the MAINTAINERS file to record this information on a
per-subsystem basis.  This commit does just that, and a subsequent
commit tags the designated reviewer for the RCU-related subsystems.

http://lists.linuxfoundation.org/pipermail/ksummit-discuss/2014-May/000830.html

Suggested-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6dc67b1fdb50..8513adb1135d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -70,6 +70,8 @@ Descriptions of section entries:
 
 	P: Person (obsolete)
 	M: Mail patches to: FullName <address@domain>
+	R: Designated reviewer, who should be CCed on patches,
+	   format: FullName <address@domain>
 	L: Mailing list that is relevant to this area
 	W: Web-page with status/info
 	Q: Patchwork web based patch tracking system site
-- 
1.8.1.5

[PATCH v2 RFC 2/3] rcu: Add designated reviewers for RCU

[Paul E. McKenney]

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

Adding Steven Rostedt and Mathieu Desnoyers as designated RCU reviewers
based on recent emails:

o	https://lkml.org/lkml/2014/6/2/578 (Steven)
o	https://lkml.org/lkml/2014/6/2/621 (Mathieu)

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8513adb1135d..83f8017575ae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7321,6 +7321,8 @@ F:	kernel/rcu/torture.c
 
 RCUTORTURE TEST FRAMEWORK
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+R:	Steven Rostedt <rostedt@goodmis.org>
+R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
@@ -7345,6 +7347,8 @@ F:	net/rds/
 READ-COPY UPDATE (RCU)
 M:	Dipankar Sarma <dipankar@in.ibm.com>
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+R:	Steven Rostedt <rostedt@goodmis.org>
+R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
 W:	http://www.rdrop.com/users/paulmck/RCU/
 S:	Supported
@@ -8098,6 +8102,8 @@ F:	mm/sl?b.c
 SLEEPABLE READ-COPY UPDATE (SRCU)
 M:	Lai Jiangshan <laijs@cn.fujitsu.com>
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+R:	Steven Rostedt <rostedt@goodmis.org>
+R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
 W:	http://www.rdrop.com/users/paulmck/RCU/
 S:	Supported
-- 
1.8.1.5

[PATCH v2 RFC 3/3] Update RCU maintainership

[Paul E. McKenney]

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

Drop Dipankar Sarma at his request (https://lkml.org/lkml/2014/6/2/628),
add Josh Triplett based on long-term review, contributions, and
agreement to take on this role (https://lkml.org/lkml/2014/6/2/554).

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 83f8017575ae..c09a24e9791f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7321,6 +7321,7 @@ F:	kernel/rcu/torture.c
 
 RCUTORTURE TEST FRAMEWORK
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+M:	Josh Triplett <josh@joshtriplett.org>
 R:	Steven Rostedt <rostedt@goodmis.org>
 R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
@@ -7345,8 +7346,8 @@ S:	Supported
 F:	net/rds/
 
 READ-COPY UPDATE (RCU)
-M:	Dipankar Sarma <dipankar@in.ibm.com>
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+M:	Josh Triplett <josh@joshtriplett.org>
 R:	Steven Rostedt <rostedt@goodmis.org>
 R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
@@ -8102,6 +8103,7 @@ F:	mm/sl?b.c
 SLEEPABLE READ-COPY UPDATE (SRCU)
 M:	Lai Jiangshan <laijs@cn.fujitsu.com>
 M:	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
+M:	Josh Triplett <josh@joshtriplett.org>
 R:	Steven Rostedt <rostedt@goodmis.org>
 R:	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
 L:	linux-kernel@vger.kernel.org
-- 
1.8.1.5

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Steven Rostedt]

On Tue,  3 Jun 2014 08:35:34 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> 
> A ksummit-discuss email thread looked at the difficulty recruiting
> and retaining reviewers.  Paul Walmsley also noted the need for patch
> submitters to know who the key reviewers are and suggested adding an
> "R:" tag to the MAINTAINERS file to record this information on a
> per-subsystem basis.  This commit does just that, and a subsequent
> commit tags the designated reviewer for the RCU-related subsystems.
> 
> http://lists.linuxfoundation.org/pipermail/ksummit-discuss/2014-May/000830.html
> 
> Suggested-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6dc67b1fdb50..8513adb1135d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -70,6 +70,8 @@ Descriptions of section entries:
>  
>  	P: Person (obsolete)
>  	M: Mail patches to: FullName <address@domain>
> +	R: Designated reviewer, who should be CCed on patches,
> +	   format: FullName <address@domain>
>  	L: Mailing list that is relevant to this area
>  	W: Web-page with status/info
>  	Q: Patchwork web based patch tracking system site

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Joe Perches]

On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> Paul Walmsley also noted the need for patch
> submitters to know who the key reviewers are and suggested adding an
> "R:" tag to the MAINTAINERS file to record this information on a
> per-subsystem basis.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -70,6 +70,8 @@ Descriptions of section entries:
>  
>  	P: Person (obsolete)
>  	M: Mail patches to: FullName <address@domain>
> +	R: Designated reviewer, who should be CCed on patches,
> +	   format: FullName <address@domain>
>  	L: Mailing list that is relevant to this area
>  	W: Web-page with status/info
>  	Q: Patchwork web based patch tracking system site

Perhaps the M: and R: roles should be more fully
described here.

The R: entry description doesn't need commas.

Maybe something like:
	M: Maintainer (to:) FullName <address@domain>
	R: Reviewer   (cc:) FullName <address@domain>

You might as well send the get_maintainer update with this
series too.

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Paul E. McKenney]

On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > Paul Walmsley also noted the need for patch
> > submitters to know who the key reviewers are and suggested adding an
> > "R:" tag to the MAINTAINERS file to record this information on a
> > per-subsystem basis.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -70,6 +70,8 @@ Descriptions of section entries:
> >  
> >  	P: Person (obsolete)
> >  	M: Mail patches to: FullName <address@domain>
> > +	R: Designated reviewer, who should be CCed on patches,
> > +	   format: FullName <address@domain>
> >  	L: Mailing list that is relevant to this area
> >  	W: Web-page with status/info
> >  	Q: Patchwork web based patch tracking system site
> 
> Perhaps the M: and R: roles should be more fully
> described here.
> 
> The R: entry description doesn't need commas.
> 
> Maybe something like:
> 	M: Maintainer (to:) FullName <address@domain>
> 	R: Reviewer   (cc:) FullName <address@domain>

This is arguably better organized, but I need to keep my focus on adding
the designated reviewer.  I am not in a position to undertake a rewrite
of the MAINTAINER file preamble at this point.

> You might as well send the get_maintainer update with this
> series too.

Interesting...  Who is the maintainer for get_maintainer?  ;-)

							Thanx, Paul

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Joe Perches]

On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote:
> On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > > Paul Walmsley also noted the need for patch
> > > submitters to know who the key reviewers are and suggested adding an
> > > "R:" tag to the MAINTAINERS file to record this information on a
> > > per-subsystem basis.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > > @@ -70,6 +70,8 @@ Descriptions of section entries:
> > >  
> > >  	P: Person (obsolete)
> > >  	M: Mail patches to: FullName <address@domain>
> > > +	R: Designated reviewer, who should be CCed on patches,
> > > +	   format: FullName <address@domain>
> > >  	L: Mailing list that is relevant to this area
> > >  	W: Web-page with status/info
> > >  	Q: Patchwork web based patch tracking system site
> > 
> > Perhaps the M: and R: roles should be more fully
> > described here.
> > 
> > The R: entry description doesn't need commas.
> > 
> > Maybe something like:
> > 	M: Maintainer (to:) FullName <address@domain>
> > 	R: Reviewer   (cc:) FullName <address@domain>
> 
> This is arguably better organized, but I need to keep my focus on adding
> the designated reviewer.  I am not in a position to undertake a rewrite
> of the MAINTAINER file preamble at this point.

That's silly, you're adding the "R" entry.
Add a proper description for it.

> > You might as well send the get_maintainer update with this
> > series too.
> 
> Interesting...  Who is the maintainer for get_maintainer?  ;-)

Some numbskull just signed up for that.

He suggests you keep all the patches that add
support for this "R: reviewer" feature together.

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Paul E. McKenney]

On Tue, Jun 03, 2014 at 01:16:07PM -0700, Joe Perches wrote:
> On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote:
> > On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> > > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > > > Paul Walmsley also noted the need for patch
> > > > submitters to know who the key reviewers are and suggested adding an
> > > > "R:" tag to the MAINTAINERS file to record this information on a
> > > > per-subsystem basis.
> > > []
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > []
> > > > @@ -70,6 +70,8 @@ Descriptions of section entries:
> > > >  
> > > >  	P: Person (obsolete)
> > > >  	M: Mail patches to: FullName <address@domain>
> > > > +	R: Designated reviewer, who should be CCed on patches,
> > > > +	   format: FullName <address@domain>
> > > >  	L: Mailing list that is relevant to this area
> > > >  	W: Web-page with status/info
> > > >  	Q: Patchwork web based patch tracking system site
> > > 
> > > Perhaps the M: and R: roles should be more fully
> > > described here.
> > > 
> > > The R: entry description doesn't need commas.
> > > 
> > > Maybe something like:
> > > 	M: Maintainer (to:) FullName <address@domain>
> > > 	R: Reviewer   (cc:) FullName <address@domain>
> > 
> > This is arguably better organized, but I need to keep my focus on adding
> > the designated reviewer.  I am not in a position to undertake a rewrite
> > of the MAINTAINER file preamble at this point.
> 
> That's silly, you're adding the "R" entry.
> Add a proper description for it.

I will take another look at R: in a few days and possibly wordsmith it.

> > > You might as well send the get_maintainer update with this
> > > series too.
> > 
> > Interesting...  Who is the maintainer for get_maintainer?  ;-)
> 
> Some numbskull just signed up for that.
> 
> He suggests you keep all the patches that add
> support for this "R: reviewer" feature together.

My reluctance is due to the fact that this will change how newbies
submit patches.  But if we get a few Acked-by or Reviewed-by responses
from high-level maintainers (Linus, Greg, Ingo, Thomas, Peter, Ted,
Dave, Ben, ...), I will of course be happy to queue it.

							Thanx, Paul

Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

[Joe Perches]

On Tue, 2014-06-03 at 14:48 -0700, Paul E. McKenney wrote:
> On Tue, Jun 03, 2014 at 01:16:07PM -0700, Joe Perches wrote:
> > On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote:
> > > On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> > > > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > > > > Paul Walmsley also noted the need for patch
> > > > > submitters to know who the key reviewers are and suggested adding an
> > > > > "R:" tag to the MAINTAINERS file to record this information on a
> > > > > per-subsystem basis.
> > > > []
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > []
> > > > > @@ -70,6 +70,8 @@ Descriptions of section entries:
> > > > >  
> > > > >  	P: Person (obsolete)
> > > > >  	M: Mail patches to: FullName <address@domain>
> > > > > +	R: Designated reviewer, who should be CCed on patches,
> > > > > +	   format: FullName <address@domain>
> > > > >  	L: Mailing list that is relevant to this area
> > > > >  	W: Web-page with status/info
> > > > >  	Q: Patchwork web based patch tracking system site
> > > > 
> > > > Perhaps the M: and R: roles should be more fully
> > > > described here.
> > > > 
> > > > The R: entry description doesn't need commas.
> > > > 
> > > > Maybe something like:
> > > > 	M: Maintainer (to:) FullName <address@domain>
> > > > 	R: Reviewer   (cc:) FullName <address@domain>
> > > 
> > > This is arguably better organized, but I need to keep my focus on adding
> > > the designated reviewer.  I am not in a position to undertake a rewrite
> > > of the MAINTAINER file preamble at this point.
> > 
> > That's silly, you're adding the "R" entry.
> > Add a proper description for it.
> 
> I will take another look at R: in a few days and possibly wordsmith it.

Swell, thanks.

> My reluctance is due to the fact that this will change how newbies
> submit patches.

Very, very doubtful that will change.

> But if we get a few Acked-by or Reviewed-by responses
> from high-level maintainers (Linus, Greg, Ingo, Thomas, Peter, Ted,
> Dave, Ben, ...), I will of course be happy to queue it.

cheers, Joe