From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix debug prints relevant to PCI devices
Date: Thu, 5 Jun 2014 00:46:57 +0100 [thread overview]
Message-ID: <20140604234657.GD23430@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <538F738A.6020003@wwwdotorg.org>
On Wed, Jun 04, 2014 at 01:29:14PM -0600, Stephen Warren wrote:
> On 06/04/2014 01:17 PM, Vidya Sagar wrote:
> > As per PCIe spec, fast back-to-back transactions feature
> > is not applicable to PCIe devices. Hence, do not print
> > that fast back-to-back trasactions are disabled when
> > there is a PCIe device found on the bus
>
> > @@ -298,6 +299,8 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> > list_for_each_entry(dev, &bus->devices, bus_list) {
> > u16 status;
> >
> > + if (!has_pcie_dev)
> > + has_pcie_dev = pci_pcie_cap(dev);
>
> This sets the flag if any PCIe device is detected, even if regular PCI
> devices are also detected. I assume the two can be mixed on a bus if
> there's a bridge (although perhaps that would be separate buses, and
> child buses don't get traversed by this function?)
This function gets caller per PCI bus - if there's a bridge between
(which there should be between PCIe and PCI) then they are by definition
separate buses. (I'm guessing that there aren't transparent bridges
between PCI and PCIe.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
bhelgaas@google.com, wangyijing@huawei.com,
thierry.reding@gmail.com, jason@lakedaemon.net,
will.deacon@arm.com, swarren@nvidia.com, kthota@nvidia.com,
sagar.tv@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: fix debug prints relevant to PCI devices
Date: Thu, 5 Jun 2014 00:46:57 +0100 [thread overview]
Message-ID: <20140604234657.GD23430@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <538F738A.6020003@wwwdotorg.org>
On Wed, Jun 04, 2014 at 01:29:14PM -0600, Stephen Warren wrote:
> On 06/04/2014 01:17 PM, Vidya Sagar wrote:
> > As per PCIe spec, fast back-to-back transactions feature
> > is not applicable to PCIe devices. Hence, do not print
> > that fast back-to-back trasactions are disabled when
> > there is a PCIe device found on the bus
>
> > @@ -298,6 +299,8 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> > list_for_each_entry(dev, &bus->devices, bus_list) {
> > u16 status;
> >
> > + if (!has_pcie_dev)
> > + has_pcie_dev = pci_pcie_cap(dev);
>
> This sets the flag if any PCIe device is detected, even if regular PCI
> devices are also detected. I assume the two can be mixed on a bus if
> there's a bridge (although perhaps that would be separate buses, and
> child buses don't get traversed by this function?)
This function gets caller per PCI bus - if there's a bridge between
(which there should be between PCIe and PCI) then they are by definition
separate buses. (I'm guessing that there aren't transparent bridges
between PCI and PCIe.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-06-04 23:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:17 [PATCH] ARM: fix debug prints relevant to PCI devices Vidya Sagar
2014-06-04 19:17 ` Vidya Sagar
2014-06-04 19:29 ` Stephen Warren
2014-06-04 19:29 ` Stephen Warren
2014-06-04 21:04 ` Jason Gunthorpe
2014-06-04 21:04 ` Jason Gunthorpe
2014-06-04 23:46 ` Russell King - ARM Linux [this message]
2014-06-04 23:46 ` Russell King - ARM Linux
2014-06-04 19:32 ` Sergei Shtylyov
2014-06-04 19:32 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604234657.GD23430@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.