* [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name.
@ 2014-06-04 18:47 Rodrigo Vivi
2014-06-04 18:50 ` Rodrigo Vivi
2014-06-04 19:55 ` Paulo Zanoni
0 siblings, 2 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2014-06-04 18:47 UTC (permalink / raw)
To: intel-gfx
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
index e768207..b5448d8 100644
--- a/drivers/gpu/drm/i915/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/intel_fbdev.c
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
/* No preferred mode marked by the EDID? Are there any modes? */
if (!modes[i] && !list_empty(&connector->modes)) {
DRM_DEBUG_KMS("using first mode listed on connector %s\n",
- drm_get_connector_name(connector));
+ connector->name);
modes[i] = list_first_entry(&connector->modes,
struct drm_display_mode,
head);
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name.
2014-06-04 18:47 [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name Rodrigo Vivi
@ 2014-06-04 18:50 ` Rodrigo Vivi
2014-06-04 19:55 ` Paulo Zanoni
1 sibling, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2014-06-04 18:50 UTC (permalink / raw)
To: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1227 bytes --]
This is breaking -nightly build!
On Wed, Jun 4, 2014 at 11:47 AM, Rodrigo Vivi <rodrigo.vivi@gmail.com>
wrote:
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
> b/drivers/gpu/drm/i915/intel_fbdev.c
> index e768207..b5448d8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct
> drm_fb_helper *fb_helper,
> /* No preferred mode marked by the EDID? Are there any
> modes? */
> if (!modes[i] && !list_empty(&connector->modes)) {
> DRM_DEBUG_KMS("using first mode listed on
> connector %s\n",
> - drm_get_connector_name(connector));
> + connector->name);
> modes[i] = list_first_entry(&connector->modes,
> struct
> drm_display_mode,
> head);
> --
> 1.9.3
>
>
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
[-- Attachment #1.2: Type: text/html, Size: 1975 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name.
2014-06-04 18:47 [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name Rodrigo Vivi
2014-06-04 18:50 ` Rodrigo Vivi
@ 2014-06-04 19:55 ` Paulo Zanoni
2014-06-05 9:13 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Paulo Zanoni @ 2014-06-04 19:55 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Intel Graphics Development
2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@gmail.com>:
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Yeah, this seems to make -nightly compile.
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> index e768207..b5448d8 100644
> --- a/drivers/gpu/drm/i915/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> @@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> /* No preferred mode marked by the EDID? Are there any modes? */
> if (!modes[i] && !list_empty(&connector->modes)) {
> DRM_DEBUG_KMS("using first mode listed on connector %s\n",
> - drm_get_connector_name(connector));
> + connector->name);
> modes[i] = list_first_entry(&connector->modes,
> struct drm_display_mode,
> head);
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Paulo Zanoni
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name.
2014-06-04 19:55 ` Paulo Zanoni
@ 2014-06-05 9:13 ` Daniel Vetter
2014-06-05 9:30 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2014-06-05 9:13 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: Intel Graphics Development
On Wed, Jun 04, 2014 at 04:55:20PM -0300, Paulo Zanoni wrote:
> 2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@gmail.com>:
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
>
> Yeah, this seems to make -nightly compile.
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Sorry my script for fixing up the -nightly build failed. I've spotted this
but then lost the manual fixup patch again :(
Should work now correctly and Dave is doing a backport of drm-fixes into
drm-next to resolve this. My apologies for the mess I've caused here.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> > index e768207..b5448d8 100644
> > --- a/drivers/gpu/drm/i915/intel_fbdev.c
> > +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> > @@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> > /* No preferred mode marked by the EDID? Are there any modes? */
> > if (!modes[i] && !list_empty(&connector->modes)) {
> > DRM_DEBUG_KMS("using first mode listed on connector %s\n",
> > - drm_get_connector_name(connector));
> > + connector->name);
> > modes[i] = list_first_entry(&connector->modes,
> > struct drm_display_mode,
> > head);
> > --
> > 1.9.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Paulo Zanoni
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name.
2014-06-05 9:13 ` Daniel Vetter
@ 2014-06-05 9:30 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-06-05 9:30 UTC (permalink / raw)
To: Paulo Zanoni, Dave Airlie; +Cc: Intel Graphics Development
On Thu, Jun 05, 2014 at 11:13:58AM +0200, Daniel Vetter wrote:
> On Wed, Jun 04, 2014 at 04:55:20PM -0300, Paulo Zanoni wrote:
> > 2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@gmail.com>:
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> >
> > Yeah, this seems to make -nightly compile.
> >
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Sorry my script for fixing up the -nightly build failed. I've spotted this
> but then lost the manual fixup patch again :(
>
> Should work now correctly and Dave is doing a backport of drm-fixes into
> drm-next to resolve this. My apologies for the mess I've caused here.
Forgotten to add Dave.
-Daniel
> >
> > > ---
> > > drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c
> > > index e768207..b5448d8 100644
> > > --- a/drivers/gpu/drm/i915/intel_fbdev.c
> > > +++ b/drivers/gpu/drm/i915/intel_fbdev.c
> > > @@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
> > > /* No preferred mode marked by the EDID? Are there any modes? */
> > > if (!modes[i] && !list_empty(&connector->modes)) {
> > > DRM_DEBUG_KMS("using first mode listed on connector %s\n",
> > > - drm_get_connector_name(connector));
> > > + connector->name);
> > > modes[i] = list_first_entry(&connector->modes,
> > > struct drm_display_mode,
> > > head);
> > > --
> > > 1.9.3
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> >
> >
> > --
> > Paulo Zanoni
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-05 9:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 18:47 [PATCH] drm/i915: Replace remaining drm_get_connector_name(c) by c->name Rodrigo Vivi
2014-06-04 18:50 ` Rodrigo Vivi
2014-06-04 19:55 ` Paulo Zanoni
2014-06-05 9:13 ` Daniel Vetter
2014-06-05 9:30 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.