From: Thierry Reding <thierry.reding@gmail.com>
To: "Stéphane Marchesin" <marcheu@chromium.org>
Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/tegra: Fix sequencing
Date: Thu, 5 Jun 2014 11:20:52 +0200 [thread overview]
Message-ID: <20140605092049.GC22966@ulmo> (raw)
In-Reply-To: <1400815968-1084-3-git-send-email-marcheu@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 691 bytes --]
On Thu, May 22, 2014 at 08:32:48PM -0700, Stéphane Marchesin wrote:
> I suspect this is a copy/paste error.
>
> Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
> ---
> drivers/gpu/drm/tegra/sor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Would you mind if I extend the commit message with something like the
following:
Lanes are powered up in decreasing order, so they should be
powered down in increasing order.
Also does this fix any issues in particular that you were seeing or is
it just an "oddity" that you noticed during review? At least on Venice2
it doesn't seem to matter in what order the lanes are powered up or
down.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2014-06-05 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 3:32 [PATCH 1/3] drm/tegra: Remove pixel clock rounding Stéphane Marchesin
2014-05-23 3:32 ` [PATCH 2/3] drm/tegra: Fix copy/paste error Stéphane Marchesin
2014-05-23 3:32 ` [PATCH 3/3] drm/tegra: Fix sequencing Stéphane Marchesin
2014-06-05 9:20 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605092049.GC22966@ulmo \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcheu@chromium.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.