All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: "Stéphane Marchesin" <marcheu@chromium.org>
Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/tegra: Align FB pitch
Date: Thu, 5 Jun 2014 11:40:49 +0200	[thread overview]
Message-ID: <20140605094048.GA23296@ulmo> (raw)
In-Reply-To: <1400896714-7092-1-git-send-email-marcheu@chromium.org>


[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]

On Fri, May 23, 2014 at 06:58:32PM -0700, Stéphane Marchesin wrote:
> The display controller doesn't handle non-256 byte aligned buffer
> pitches. If you give it an unaligned buffer, it will stop after the
> first line and will report underflows in the debug registers
> (DC_WINBUF_UFLOW_STATUS and friends). So let's make sure that all our
> framebuffer pitches are 256-byte aligned.
> 
> Signed-off-by: Stéphane Marchesin <marcheu@chromium.org>
> ---
>  drivers/gpu/drm/tegra/drm.h | 2 ++
>  drivers/gpu/drm/tegra/fb.c  | 3 ++-
>  drivers/gpu/drm/tegra/gem.c | 2 ++
>  3 files changed, 6 insertions(+), 1 deletion(-)

Can you point me to where this requirement is documented? I've gone
through the TRM and all I can find is that the line stride needs to be
64 byte aligned. Also I seem to remember that resolutions such as
1366x768 used to work for HDMI at least on earlier Tegra generations.
Perhaps this is a requirement that's new on Tegra124?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2014-06-05  9:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-24  1:58 [PATCH 1/3] drm/tegra: Align FB pitch Stéphane Marchesin
2014-05-24  1:58 ` [PATCH 2/3] drm/tegra: Support setting the EMC clock Stéphane Marchesin
2014-05-26  9:07   ` Lucas Stach
2014-05-26  9:28     ` Stéphane Marchesin
     [not found]       ` <CACP_E+J-sCsiiSX-apX3ZqWFHVGxgN5FG9eu9-qTjLQHF22DwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-26  9:35         ` Thierry Reding
2014-05-26  9:52           ` Stéphane Marchesin
2014-05-24  1:58 ` [PATCH 3/3] drm/tegra: Don't hardcode link parameters Stéphane Marchesin
2014-06-05  9:40 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605094048.GA23296@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=marcheu@chromium.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.