From: Christoph Hellwig <hch@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
hch@lst.de, JBottomley@Parallels.com, venkateshs@google.com,
Ulrich Obergfell <uobergfe@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 4/6] scsi_error: fix invalid setting of host byte
Date: Thu, 5 Jun 2014 03:12:42 -0700 [thread overview]
Message-ID: <20140605101242.GC8633@infradead.org> (raw)
In-Reply-To: <1401881699-1456-5-git-send-email-pbonzini@redhat.com>
On Wed, Jun 04, 2014 at 01:34:57PM +0200, Paolo Bonzini wrote:
> From: Ulrich Obergfell <uobergfe@redhat.com>
>
> After scsi_try_to_abort_cmd returns, the eh_abort_handler may have
> already found that the command has completed in the device, causing
> the host_byte to be nonzero (e.g. it could be DID_ABORT). When
> this happens, ORing DID_TIME_OUT into the host byte will corrupt
> the result field and initiate an unwanted command retry.
>
> Fix this by using set_host_byte instead, following the model of
> commit 2082ebc45af9c9c648383b8cde0dc1948eadbf31.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
> [Fix all instances according to review comments. - Paolo]
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-06-05 10:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:34 [PATCH v3 0/6] virtio-scsi patches for 3.16 + midlayer fix Paolo Bonzini
2014-06-04 11:34 ` [PATCH v3 1/6] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends() Paolo Bonzini
2014-06-05 10:11 ` Christoph Hellwig
2014-06-04 11:34 ` [PATCH v3 2/6] virtio-scsi: replace target spinlock with seqcount Paolo Bonzini
2014-06-04 11:34 ` [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items Paolo Bonzini
2014-06-05 10:12 ` Christoph Hellwig
2014-06-11 12:47 ` Christoph Hellwig
2014-06-11 13:19 ` Fwd: " Stefan Hajnoczi
2014-06-04 11:34 ` [PATCH v3 4/6] scsi_error: fix invalid setting of host byte Paolo Bonzini
2014-06-05 10:12 ` Christoph Hellwig [this message]
2014-06-04 11:34 ` [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests Paolo Bonzini
2014-06-04 17:29 ` Venkatesh Srinivas
2014-06-04 19:05 ` Paolo Bonzini
2014-06-05 3:10 ` Venkatesh Srinivas
2014-06-04 11:34 ` [PATCH v3 6/6] virtio-scsi: Implement change_queue_depth for virtscsi targets Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605101242.GC8633@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@Parallels.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=uobergfe@redhat.com \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.