From: Paolo Bonzini <pbonzini@redhat.com>
To: Venkatesh Srinivas <venkateshs@google.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
hch@lst.de, JBottomley@parallels.com, stable@vger.kernel.org,
Venkatesh Srinivas <vsrinivas@ops101.org>
Subject: Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests
Date: Wed, 04 Jun 2014 21:05:15 +0200 [thread overview]
Message-ID: <538F6DEB.2000601@redhat.com> (raw)
In-Reply-To: <CAHdzE-8KoMrg_jSuj-F9c=HnapCiLCg9bKCifduTaxx-DAJZRw@mail.gmail.com>
Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto:
> Do you really want to poll the request VQs for completions if the TMF
> was rejected?
I wasn't sure, but bugs in this path are hard enough that I preferred
the safer patch.
> TMF ABORT may return FUNCTION REJECTED if the command to abort
> completed before the device saw the TMF ABORT message, for example. In
> such cases, this would
> unnecessarily lengthen the EH path.
The cost of virtscsi_poll_requests should be nothing compared to the
delay between the timeout and the invocation of the delayed_work, no?
Paolo
next prev parent reply other threads:[~2014-06-04 19:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:34 [PATCH v3 0/6] virtio-scsi patches for 3.16 + midlayer fix Paolo Bonzini
2014-06-04 11:34 ` [PATCH v3 1/6] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends() Paolo Bonzini
2014-06-05 10:11 ` Christoph Hellwig
2014-06-04 11:34 ` [PATCH v3 2/6] virtio-scsi: replace target spinlock with seqcount Paolo Bonzini
2014-06-04 11:34 ` [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items Paolo Bonzini
2014-06-05 10:12 ` Christoph Hellwig
2014-06-11 12:47 ` Christoph Hellwig
2014-06-11 13:19 ` Fwd: " Stefan Hajnoczi
2014-06-04 11:34 ` [PATCH v3 4/6] scsi_error: fix invalid setting of host byte Paolo Bonzini
2014-06-05 10:12 ` Christoph Hellwig
2014-06-04 11:34 ` [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests Paolo Bonzini
2014-06-04 17:29 ` Venkatesh Srinivas
2014-06-04 19:05 ` Paolo Bonzini [this message]
2014-06-05 3:10 ` Venkatesh Srinivas
2014-06-04 11:34 ` [PATCH v3 6/6] virtio-scsi: Implement change_queue_depth for virtscsi targets Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F6DEB.2000601@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@parallels.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=venkateshs@google.com \
--cc=vsrinivas@ops101.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.