From: antoine.tenart@free-electrons.com (Antoine Ténart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] usb: chipidea: add Berlin USB support
Date: Fri, 6 Jun 2014 14:01:53 +0200 [thread overview]
Message-ID: <20140606120153.GC32416@kwain> (raw)
In-Reply-To: <53919E3A.7070008@gmail.com>
Sebastian,
On Fri, Jun 06, 2014 at 12:55:54PM +0200, Sebastian Hesselbarth wrote:
> On 06/05/2014 05:48 PM, Antoine T?nart wrote:
> >+
> >+static const struct of_device_id ci_hdrc_berlin_of_match[] = {
> >+ { .compatible = "marvell,berlin-usb" },
>
> Looking at the driver, I can see no Berlin-specific code at all. Maybe
> we just take the chance and have a generic chipidea boiler plate driver
> now?
This driver does nothing special. If we define the PHY and the clock
properties as optional, we can do a generic driver here.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
Peter.Chen@freescale.com, alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] usb: chipidea: add Berlin USB support
Date: Fri, 6 Jun 2014 14:01:53 +0200 [thread overview]
Message-ID: <20140606120153.GC32416@kwain> (raw)
In-Reply-To: <53919E3A.7070008@gmail.com>
Sebastian,
On Fri, Jun 06, 2014 at 12:55:54PM +0200, Sebastian Hesselbarth wrote:
> On 06/05/2014 05:48 PM, Antoine Ténart wrote:
> >+
> >+static const struct of_device_id ci_hdrc_berlin_of_match[] = {
> >+ { .compatible = "marvell,berlin-usb" },
>
> Looking at the driver, I can see no Berlin-specific code at all. Maybe
> we just take the chance and have a generic chipidea boiler plate driver
> now?
This driver does nothing special. If we define the PHY and the clock
properties as optional, we can do a generic driver here.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-06 12:01 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 15:48 [PATCH 0/9] ARM: Berlin: USB support Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 1/9] reset: add the Berlin reset controller driver Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 16:36 ` Philipp Zabel
2014-06-05 16:36 ` Philipp Zabel
2014-06-05 16:56 ` Antoine Ténart
2014-06-05 16:56 ` Antoine Ténart
2014-06-06 10:44 ` Sebastian Hesselbarth
2014-06-06 10:44 ` Sebastian Hesselbarth
2014-06-09 10:32 ` Sebastian Hesselbarth
2014-06-09 10:32 ` Sebastian Hesselbarth
2014-06-09 11:23 ` Philipp Zabel
2014-06-09 11:23 ` Philipp Zabel
2014-06-05 15:48 ` [PATCH 2/9] ARM: Berlin: select the reset controller Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 3/9] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 16:39 ` Philipp Zabel
2014-06-05 16:39 ` Philipp Zabel
2014-06-05 16:39 ` Philipp Zabel
2014-06-05 16:44 ` Antoine Ténart
2014-06-05 16:44 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 4/9] usb: phy: add the Berlin USB PHY driver Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-06 6:39 ` Vivek Gautam
2014-06-06 6:39 ` Vivek Gautam
2014-06-06 7:11 ` Antoine Ténart
2014-06-06 7:11 ` Antoine Ténart
2014-06-06 11:02 ` Vivek Gautam
2014-06-06 11:02 ` Vivek Gautam
2014-06-19 13:45 ` Felipe Balbi
2014-06-19 13:45 ` Felipe Balbi
2014-06-06 10:54 ` Sebastian Hesselbarth
2014-06-06 10:54 ` Sebastian Hesselbarth
2014-06-06 11:59 ` Antoine Ténart
2014-06-06 11:59 ` Antoine Ténart
2014-06-09 8:26 ` Jisheng Zhang
2014-06-09 8:26 ` Jisheng Zhang
2014-06-09 10:11 ` Sebastian Hesselbarth
2014-06-09 10:11 ` Sebastian Hesselbarth
2014-06-09 10:52 ` Alexandre Belloni
2014-06-09 10:52 ` Alexandre Belloni
2014-06-05 15:48 ` [PATCH 5/9] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 6/9] usb: chipidea: add Berlin USB support Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-06 10:55 ` Sebastian Hesselbarth
2014-06-06 10:55 ` Sebastian Hesselbarth
2014-06-06 12:01 ` Antoine Ténart [this message]
2014-06-06 12:01 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 7/9] Documentation: bindings: add doc for the Berlin ChipIdea USB driver Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 8/9] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-05 15:48 ` [PATCH 9/9] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-06-05 15:48 ` Antoine Ténart
2014-06-09 4:30 ` [PATCH 0/9] ARM: Berlin: USB support Peter Chen
2014-06-09 4:30 ` Peter Chen
2014-06-09 4:30 ` Peter Chen
2014-06-09 10:14 ` Sebastian Hesselbarth
2014-06-09 10:14 ` Sebastian Hesselbarth
2014-06-09 10:14 ` Sebastian Hesselbarth
2014-06-10 1:16 ` Peter Chen
2014-06-10 1:16 ` Peter Chen
2014-06-10 1:16 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606120153.GC32416@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.