From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] vdi: remove double conversion
Date: Fri, 6 Jun 2014 16:14:54 +0200 [thread overview]
Message-ID: <20140606141453.GE16494@irqsave.net> (raw)
In-Reply-To: <1402063613-12400-1-git-send-email-pbonzini@redhat.com>
The Friday 06 Jun 2014 à 16:06:52 (+0200), Paolo Bonzini wrote :
> This should be a problem when running on big-endian machines.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> It's time to clean up old branch, and I found this nice little
> patch from May 2012.
>
> block/vdi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 119d3c7..993430e 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -237,7 +237,6 @@ static void vdi_header_to_le(VdiHeader *header)
> cpu_to_le32s(&header->block_extra);
> cpu_to_le32s(&header->blocks_in_image);
> cpu_to_le32s(&header->blocks_allocated);
> - cpu_to_le32s(&header->blocks_allocated);
> uuid_convert(header->uuid_image);
> uuid_convert(header->uuid_last_snap);
> uuid_convert(header->uuid_link);
> --
> 1.8.3.1
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
WARNING: multiple messages have this Message-ID (diff)
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vdi: remove double conversion
Date: Fri, 6 Jun 2014 16:14:54 +0200 [thread overview]
Message-ID: <20140606141453.GE16494@irqsave.net> (raw)
In-Reply-To: <1402063613-12400-1-git-send-email-pbonzini@redhat.com>
The Friday 06 Jun 2014 à 16:06:52 (+0200), Paolo Bonzini wrote :
> This should be a problem when running on big-endian machines.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> It's time to clean up old branch, and I found this nice little
> patch from May 2012.
>
> block/vdi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 119d3c7..993430e 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -237,7 +237,6 @@ static void vdi_header_to_le(VdiHeader *header)
> cpu_to_le32s(&header->block_extra);
> cpu_to_le32s(&header->blocks_in_image);
> cpu_to_le32s(&header->blocks_allocated);
> - cpu_to_le32s(&header->blocks_allocated);
> uuid_convert(header->uuid_image);
> uuid_convert(header->uuid_last_snap);
> uuid_convert(header->uuid_link);
> --
> 1.8.3.1
>
>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
next prev parent reply other threads:[~2014-06-06 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:06 [Qemu-trivial] [PATCH] vdi: remove double conversion Paolo Bonzini
2014-06-06 14:06 ` [Qemu-devel] " Paolo Bonzini
2014-06-06 14:06 ` [Qemu-trivial] [PATCH] x86: correctly implement soft reset Paolo Bonzini
2014-06-06 14:06 ` [Qemu-devel] " Paolo Bonzini
2014-06-06 14:53 ` Paolo Bonzini
2014-06-08 13:15 ` [Qemu-trivial] " Michael Tokarev
2014-06-08 13:15 ` [Qemu-devel] " Michael Tokarev
2014-06-21 15:12 ` Michael Tokarev
2014-06-21 15:12 ` [Qemu-devel] " Michael Tokarev
2014-06-23 11:50 ` Paolo Bonzini
2014-06-23 11:50 ` [Qemu-devel] " Paolo Bonzini
2014-06-06 14:14 ` Benoît Canet [this message]
2014-06-06 14:14 ` [Qemu-devel] [PATCH] vdi: remove double conversion Benoît Canet
2014-06-08 14:43 ` [Qemu-trivial] " Stefan Weil
2014-06-08 14:43 ` Stefan Weil
2014-06-08 13:14 ` [Qemu-trivial] " Michael Tokarev
2014-06-08 13:14 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606141453.GE16494@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.