From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915: fix possible refcount leak when resetting forcewake
Date: Fri, 6 Jun 2014 19:46:19 +0200 [thread overview]
Message-ID: <20140606174619.GS7416@phenom.ffwll.local> (raw)
In-Reply-To: <20140606110843.GF22214@nuc-i3427.alporthouse.com>
On Fri, Jun 06, 2014 at 12:08:43PM +0100, Chris Wilson wrote:
> On Fri, Jun 06, 2014 at 02:04:37PM +0300, Imre Deak wrote:
> > If the timer putting the last forcewake refcount was pending and we
> > canceled it, we'll leak the corresponding forcewake and RPM references.
> >
> > v2:
> > - do the ptr casting at the caller instead of adding a separate helper
> > for this (Chris)
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Both patches merged to dinq (Chris clarified on irc that his r-b is for
both). Since this only blows up in a super-contrived testcase I don't
think this is material for -fixes.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-06-06 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 9:59 [PATCH 1/2] drm/i915: fix possible refcount leak when resetting forcewake Imre Deak
2014-06-06 9:59 ` [PATCH 2/2] drm/i915: preserve user forcewake over system suspend/resume Imre Deak
2014-06-06 10:03 ` [PATCH 1/2] drm/i915: fix possible refcount leak when resetting forcewake Chris Wilson
2014-06-06 11:04 ` [PATCH v2 " Imre Deak
2014-06-06 11:08 ` Chris Wilson
2014-06-06 17:46 ` Daniel Vetter [this message]
2014-06-06 18:38 ` Imre Deak
2014-06-06 20:15 ` Daniel Vetter
2014-06-06 20:19 ` Imre Deak
2014-06-06 20:35 ` Daniel Vetter
2014-06-06 20:44 ` Imre Deak
2014-06-06 20:54 ` Daniel Vetter
2014-06-10 16:35 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606174619.GS7416@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.