From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Imre Deak <imre.deak@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/2] drm/i915: fix possible refcount leak when resetting forcewake
Date: Tue, 10 Jun 2014 19:35:53 +0300 [thread overview]
Message-ID: <87bnu0u3h2.fsf@intel.com> (raw)
In-Reply-To: <CAKMK7uG+uXTigjBQphizq0cCN15V7gcVifxPpgiJXGJ=jxu0qg@mail.gmail.com>
On Fri, 06 Jun 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Jun 6, 2014 at 10:44 PM, Imre Deak <imre.deak@intel.com> wrote:
>> Let's say that forcewake timer is pending, holding the runtime pm ref.
>> System suspend is called - it's not prevented by either this ref or the
>> above autosuspend delay - in the suspend handler we eventually call
>> force_wake_reset which cancels the timer, leaking the runtime pm ref.
>
> Hm, I indeed mixed things up. I guess the window is small with the
> short timeout we have for the forcewake timer, but still the first
> patch makes sense for -fixes. Jani?
v2 of 1/2 pushed to -fixes, thanks for that patch and review.
BR,
Jani.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-06-10 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 9:59 [PATCH 1/2] drm/i915: fix possible refcount leak when resetting forcewake Imre Deak
2014-06-06 9:59 ` [PATCH 2/2] drm/i915: preserve user forcewake over system suspend/resume Imre Deak
2014-06-06 10:03 ` [PATCH 1/2] drm/i915: fix possible refcount leak when resetting forcewake Chris Wilson
2014-06-06 11:04 ` [PATCH v2 " Imre Deak
2014-06-06 11:08 ` Chris Wilson
2014-06-06 17:46 ` Daniel Vetter
2014-06-06 18:38 ` Imre Deak
2014-06-06 20:15 ` Daniel Vetter
2014-06-06 20:19 ` Imre Deak
2014-06-06 20:35 ` Daniel Vetter
2014-06-06 20:44 ` Imre Deak
2014-06-06 20:54 ` Daniel Vetter
2014-06-10 16:35 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnu0u3h2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.